Bug 68676 - GetScopedVar should have value profiling
Summary: GetScopedVar should have value profiling
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 68677
  Show dependency treegraph
Reported: 2011-09-22 20:28 PDT by Filip Pizlo
Modified: 2011-09-22 23:58 PDT (History)
1 user (show)

See Also:

the patch (7.13 KB, patch)
2011-09-22 21:47 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-09-22 20:28:42 PDT
The GetScopedVar in the DFG currently has no value profiling information available to it.
Comment 1 Filip Pizlo 2011-09-22 20:32:17 PDT
This blocks https://bugs.webkit.org/show_bug.cgi?id=68677 because we don't want to turn off static speculation when we are actively emitting heap loads while having zero information about what they load.
Comment 2 Filip Pizlo 2011-09-22 21:47:40 PDT
Created attachment 108439 [details]
the patch

Performance neutral.
Comment 3 Oliver Hunt 2011-09-22 21:48:57 PDT
Comment on attachment 108439 [details]
the patch

Comment 4 WebKit Review Bot 2011-09-22 23:58:46 PDT
Comment on attachment 108439 [details]
the patch

Clearing flags on attachment: 108439

Committed r95786: <http://trac.webkit.org/changeset/95786>
Comment 5 WebKit Review Bot 2011-09-22 23:58:50 PDT
All reviewed patches have been landed.  Closing bug.