Bug 68644 - Add APIObjects for Size, Point, Rect
Summary: Add APIObjects for Size, Point, Rect
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
Depends on:
Blocks: 68453
  Show dependency treegraph
Reported: 2011-09-22 11:18 PDT by Simon Fraser (smfr)
Modified: 2011-09-22 15:49 PDT (History)
4 users (show)

See Also:

Patch (22.96 KB, patch)
2011-09-22 13:16 PDT, Simon Fraser (smfr)
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-09-22 11:18:04 PDT
Need to add WebKit2 APIObjects for size, point, rect.
Comment 1 Simon Fraser (smfr) 2011-09-22 13:16:24 PDT
Created attachment 108388 [details]
Comment 2 WebKit Review Bot 2011-09-22 13:18:56 PDT
Attachment 108388 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/Shared/WebGeometry.h:35:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 13 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2011-09-22 14:37:07 PDT
Comment on attachment 108388 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=108388&action=review

> Source/WebKit2/Shared/API/c/WKBase.h:138
> +#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L
> +#define WK_INLINE static inline

What does this mean?
Comment 4 Simon Fraser (smfr) 2011-09-22 15:49:01 PDT