WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
68644
Add APIObjects for Size, Point, Rect
https://bugs.webkit.org/show_bug.cgi?id=68644
Summary
Add APIObjects for Size, Point, Rect
Simon Fraser (smfr)
Reported
2011-09-22 11:18:04 PDT
Need to add WebKit2 APIObjects for size, point, rect.
Attachments
Patch
(22.96 KB, patch)
2011-09-22 13:16 PDT
,
Simon Fraser (smfr)
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2011-09-22 13:16:24 PDT
Created
attachment 108388
[details]
Patch
WebKit Review Bot
Comment 2
2011-09-22 13:18:56 PDT
Attachment 108388
[details]
did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/Shared/WebGeometry.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2011-09-22 14:37:07 PDT
Comment on
attachment 108388
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=108388&action=review
> Source/WebKit2/Shared/API/c/WKBase.h:138 > +#if defined(__STDC_VERSION__) && __STDC_VERSION__ >= 199901L > +#define WK_INLINE static inline
What does this mean?
Simon Fraser (smfr)
Comment 4
2011-09-22 15:49:01 PDT
http://trac.webkit.org/changeset/95759
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug