Bug 68453 – Repaint tests don't work in WebKit2

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Simon Fraser (smfr)]

layoutTestController.display() does nothing in WebKit2. Making it behave the same way as WK1 is tricky, because the WebProcess would have to retain a bitmap for the entire page, with the alpha wash, and then copy parts over to the UI process.

A better solution is to keep track of the repaint rects in WebCore, and add layout test controller API to retrieve them. We can then use these rects to synthesize the repaint pixel results.

[Simon Fraser (smfr)]

Created attachment 108373 [details]
Have FrameView track repaint rects and expose them in WK1

[Adam Roben (:aroben)]

Comment on attachment 108373 [details]
Have FrameView track repaint rects and expose them in WK1

View in context: https://bugs.webkit.org/attachment.cgi?id=108373&action=review

> Source/WebKit/mac/WebView/WebViewPrivate.h:499
> +- (void)setTracksRepaints:(BOOL)flag;
> +- (BOOL)isTrackingRepaints;
> +- (void)resetTrackedRepaints;
> +- (NSArray*)trackedRepaintRects; // Returned array contains rectValue NSValues.

Do we need WebKit SPI for this? Can DRT make calls directly to window.internals from native code?

[Adam Barth]

+dglazkov for the window.internals question.

[Simon Fraser (smfr)]

Created attachment 108567 [details]
Have FrameView track repaint rects and expose them in WK1

[Simon Fraser (smfr)]

Comment on attachment 108567 [details]
Have FrameView track repaint rects and expose them in WK1

Change from the previous patch is to have FrameView unapply the scroll offset from the rects.

[Simon Fraser (smfr)]

Created attachment 108569 [details]
Expose repaint rects through WK2 private API

[Simon Fraser (smfr)]

Created attachment 108571 [details]
Use the repaint rects to generate the repaint overlay in DRT and WTR

[WebKit Review Bot]

Comment on attachment 108569 [details]
Expose repaint rects through WK2 private API

Attachment 108569 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9840142

[Gustavo Noronha (kov)]

Comment on attachment 108569 [details]
Expose repaint rects through WK2 private API

Attachment 108569 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9844242

[Collabora GTK+ EWS bot]

Comment on attachment 108571 [details]
Use the repaint rects to generate the repaint overlay in DRT and WTR

Attachment 108571 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9856002

[Simon Fraser (smfr)]

Later patches are failing because they require the FrameView changes.

[Sam Weinig]

Comment on attachment 108567 [details]
Have FrameView track repaint rects and expose them in WK1

View in context: https://bugs.webkit.org/attachment.cgi?id=108567&action=review

> Source/WebCore/page/FrameView.h:454
> +    bool m_isTrackingRepaints; // Used for testing.
> +    Vector<LayoutRect> m_trackedRepaintRects;

This seems like it should be IntRects.

[Sam Weinig]

Comment on attachment 108571 [details]
Use the repaint rects to generate the repaint overlay in DRT and WTR

View in context: https://bugs.webkit.org/attachment.cgi?id=108571&action=review

> Tools/DumpRenderTree/mac/PixelDumpSupportMac.mm:152
> +    if (repaintRects) {
> +        
> +        for (NSValue *value in repaintRects) {

Unnecessary newline.

[Simon Fraser (smfr)]

Comment on attachment 108567 [details]
Have FrameView track repaint rects and expose them in WK1

http://trac.webkit.org/changeset/95967

[Simon Fraser (smfr)]

Comment on attachment 108569 [details]
Expose repaint rects through WK2 private API

http://trac.webkit.org/changeset/95968

[Simon Fraser (smfr)]

http://trac.webkit.org/changeset/96005

[Csaba Osztrogonác]

Qt-WK2 buildfixes landed in
http://trac.webkit.org/changeset/95989 
http://trac.webkit.org/changeset/96071