Bug 68599 – [EFL] Rename ewk_tiled_*.c to ewk_tiled_*.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Ryuan Choi]

Patch will be added.

[Ryuan Choi]

Created attachment 108939 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 108939 [details]
Patch

Attachment 108939 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9879510

[Ryuan Choi]

Created attachment 108942 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 108942 [details]
Patch

Attachment 108942 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9883420

[Ryuan Choi]

(In reply to comment #4)
> (From update of attachment 108942 [details])
> Attachment 108942 [details] did not pass efl-ews (efl):
> Output: http://queues.webkit.org/results/9883420

It's because of old eina.
I'll bump eina at different bug.

Gyuyoung, Could you update build bot?

[Gyuyoung Kim]

(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 108942 [details] [details])
> > Attachment 108942 [details] [details] did not pass efl-ews (efl):
> > Output: http://queues.webkit.org/results/9883420
> 
> It's because of old eina.
> I'll bump eina at different bug.
> 
> Gyuyoung, Could you update build bot?

I update eina both ews and buildbot. Please submit your patch again.

[Ryuan Choi]

Created attachment 108999 [details]
Patch

[Ryuan Choi]

Created attachment 109000 [details]
Patch

[Ryuan Choi]

Created attachment 109117 [details]
rebased

[Gyuyoung Kim]

I wonder which codes are changed to fix compile errors. Because, it is difficult to find the changes in this patch.

[Ryuan Choi]

Created attachment 109119 [details]
diff_for_easy_review

Attached file is diff after renamed for easy review.
It is same with 109117 without renaming.

[Gyuyoung Kim]

Comment on attachment 109119 [details]
diff_for_easy_review

View in context: https://bugs.webkit.org/attachment.cgi?id=109119&action=review

> Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:834
> +    void* newItems = realloc(priv->view.items, sizeof(Eina_Inlist*) * (int)rows);

Missing to use C++ casting in (int)rows.

[Ryuan Choi]

Created attachment 109225 [details]
Patch

[Ryuan Choi]

(In reply to comment #12)
> (From update of attachment 109119 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109119&action=review
> 
> > Source/WebKit/efl/ewk/ewk_tiled_backing_store.cpp:834
> > +    void* newItems = realloc(priv->view.items, sizeof(Eina_Inlist*) * (int)rows);
> 
> Missing to use C++ casting in (int)rows.

I fixed it by removing (int). Other is same.

[Hajime Morrita]

Comment on attachment 109225 [details]
Patch

Rubberstamping.

[WebKit Review Bot]

Comment on attachment 109225 [details]
Patch

Clearing flags on attachment: 109225

Committed r96495: <http://trac.webkit.org/changeset/96495>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.