Bug 68576 - MiniBrowser fails to launch when double-clicked
Summary: MiniBrowser fails to launch when double-clicked
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, PlatformOnly
Depends on: 68578
Blocks:
  Show dependency tree / graph
 
Reported: 2011-09-21 15:25 PDT by Adam Roben (:aroben)
Modified: 2012-01-05 06:58 PST (History)
2 users (show)

See Also:

Attachments
Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code (17.78 KB, patch)
2012-01-04 11:59 PST, Adam Roben (:aroben) 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-09-21 15:25:31 PDT 
To reproduce:

1. Double-click MiniBrowser.exe

It doesn't launch. It complains about not being able to find CFNetwork.dll.
Comment 1 Radar WebKit Bug Importer 2011-09-21 15:25:57 PDT 
<rdar://problem/10163853>
Comment 2 Adam Roben (:aroben) 2011-09-21 15:36:14 PDT 
It's possible we'll be able to fix this by delay-loading WebKit.dll and setting up the DLL search path before we make any WebKit API calls.
Comment 3 Adam Roben (:aroben) 2011-09-22 09:54:08 PDT 
Looks like delay-loading isn't good enough. We're still loading WebKit.dll immediately on launch, which then pulls in CoreFoundation etc.
Comment 4 Adam Roben (:aroben) 2011-09-22 11:48:37 PDT 
Since we're going to need a stub launcher for WinLauncher, too (bug 68578), maybe we'll come up with a way to share the launcher code. We might be able to share code with WebKitLauncherWin, too.
Comment 5 Adam Roben (:aroben) 2012-01-04 11:59:29 PST 
Created attachment 121133 [details]
Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
Comment 6 Adam Roben (:aroben) 2012-01-05 06:58:32 PST 
Committed r104155: <http://trac.webkit.org/changeset/104155>