Bug 68399 - Changelog class should have a method to return all entries
Summary: Changelog class should have a method to return all entries
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leandro Pereira
URL:
Keywords:
Depends on: 68115
Blocks:
  Show dependency tree / graph
 
Reported: 2011-09-19 15:19 PDT by Leandro Pereira
Modified: 2011-09-20 09:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2011-09-19 15:24 PDT, Leandro Pereira 		no flags Details | Formatted Diff | Diff
Patch (3.59 KB, patch)
2011-09-20 09:32 PDT, Leandro Pereira 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2011-09-19 15:19:34 PDT 
Changelog class should have a method to return all entries
Comment 1 Leandro Pereira 2011-09-19 15:24:41 PDT 
Created attachment 107929 [details]
Patch
Comment 2 Leandro Pereira 2011-09-19 15:25:20 PDT 
CC'ing Ryosuke Niwa.
Comment 3 Ryosuke Niwa 2011-09-19 21:55:37 PDT 
Comment on attachment 107929 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107929&action=review

> Tools/ChangeLog:7
> +        Implement ChangeLog.parse_entries_from_file(). This method returns a
> +        generator of ChangeLogEntry objects, ordered from the latest to the

Can you put generator on the previous line? It seems odd to end a line with an article.

> Tools/ChangeLog:15
> +        * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test
> +        case.

Seems like you can hit the entire thing in one line.

> Tools/Scripts/webkitpy/common/checkout/changelog.py:171
> +            # If we've hit the next entry, return.

Nit: We don't return here, right?
Comment 4 Leandro Pereira 2011-09-20 09:30:35 PDT 
Comment on attachment 107929 [details]
Patch

Forgot to submit a new patch taking care of rniwa's comments.
Comment 5 Leandro Pereira 2011-09-20 09:32:33 PDT 
Created attachment 108011 [details]
Patch
Comment 6 WebKit Review Bot 2011-09-20 09:44:39 PDT 
Comment on attachment 108011 [details]
Patch

Clearing flags on attachment: 108011

Committed r95549: <http://trac.webkit.org/changeset/95549>
Comment 7 WebKit Review Bot 2011-09-20 09:44:45 PDT 
All reviewed patches have been landed.  Closing bug.