RESOLVED FIXED 68399
Changelog class should have a method to return all entries 
https://bugs.webkit.org/show_bug.cgi?id=68399
Summary Changelog class should have a method to return all entries
Leandro Pereira
Reported 2011-09-19 15:19:34 PDT
Changelog class should have a method to return all entries
Attachments
Patch (3.66 KB, patch)
2011-09-19 15:24 PDT, Leandro Pereira 		no flags
DetailsFormatted DiffDiff
Patch (3.59 KB, patch)
2011-09-20 09:32 PDT, Leandro Pereira 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Leandro Pereira
Comment 1 2011-09-19 15:24:41 PDT
Created attachment 107929 [details] Patch
Leandro Pereira
Comment 2 2011-09-19 15:25:20 PDT
CC'ing Ryosuke Niwa.
Ryosuke Niwa
Comment 3 2011-09-19 21:55:37 PDT
Comment on attachment 107929 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107929&action=review > Tools/ChangeLog:7 > + Implement ChangeLog.parse_entries_from_file(). This method returns a > + generator of ChangeLogEntry objects, ordered from the latest to the Can you put generator on the previous line? It seems odd to end a line with an article. > Tools/ChangeLog:15 > + * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test > + case. Seems like you can hit the entire thing in one line. > Tools/Scripts/webkitpy/common/checkout/changelog.py:171 > + # If we've hit the next entry, return. Nit: We don't return here, right?
Leandro Pereira
Comment 4 2011-09-20 09:30:35 PDT
Comment on attachment 107929 [details] Patch Forgot to submit a new patch taking care of rniwa's comments.
Leandro Pereira
Comment 5 2011-09-20 09:32:33 PDT
Created attachment 108011 [details] Patch
WebKit Review Bot
Comment 6 2011-09-20 09:44:39 PDT
Comment on attachment 108011 [details] Patch Clearing flags on attachment: 108011 Committed r95549: <http://trac.webkit.org/changeset/95549>
WebKit Review Bot
Comment 7 2011-09-20 09:44:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.