WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
68115
ChangeLogEntry class should contain a list of touched files
https://bugs.webkit.org/show_bug.cgi?id=68115
Summary
ChangeLogEntry class should contain a list of touched files
Leandro Pereira
Reported
2011-09-14 14:05:20 PDT
ChangeLogEntry class should contain a list of touched files
Attachments
Patch
(3.15 KB, patch)
2011-09-14 14:07 PDT
,
Leandro Pereira
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Leandro Pereira
Comment 1
2011-09-14 14:07:30 PDT
Created
attachment 107390
[details]
Patch
Ryosuke Niwa
Comment 2
2011-09-14 14:12:42 PDT
Comment on
attachment 107390
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=107390&action=review
> Tools/ChangeLog:8 > + Add method to return the list of files touched in a ChangeLog entry.
Nit: Add a method?
> Tools/Scripts/webkitpy/common/checkout/changelog.py:78 > + # e.g. * Source/WebCore/page/EventHandler.cpp: Implement FooBarQuux. > + touched_files_regexp = r'\s*\*\s*(?P<file>.+)\:'
Mn... files move every now and then so maybe we just want to partially match? e.g. WebCore -> Source/WebCore.
Eric Seidel (no email)
Comment 3
2011-09-14 23:26:50 PDT
Comment on
attachment 107390
[details]
Patch This seems reasonable.
WebKit Review Bot
Comment 4
2011-09-20 09:30:22 PDT
Comment on
attachment 107390
[details]
Patch Clearing flags on attachment: 107390 Committed
r95547
: <
http://trac.webkit.org/changeset/95547
>
WebKit Review Bot
Comment 5
2011-09-20 09:30:27 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug