Bug 68115 - ChangeLogEntry class should contain a list of touched files
Summary: ChangeLogEntry class should contain a list of touched files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Leandro Pereira
URL:
Keywords:
Depends on:
Blocks: 68399
  Show dependency treegraph
 
Reported: 2011-09-14 14:05 PDT by Leandro Pereira
Modified: 2011-09-20 09:30 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.15 KB, patch)
2011-09-14 14:07 PDT, Leandro Pereira
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Leandro Pereira 2011-09-14 14:05:20 PDT
ChangeLogEntry class should contain a list of touched files
Comment 1 Leandro Pereira 2011-09-14 14:07:30 PDT
Created attachment 107390 [details]
Patch
Comment 2 Ryosuke Niwa 2011-09-14 14:12:42 PDT
Comment on attachment 107390 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=107390&action=review

> Tools/ChangeLog:8
> +        Add method to return the list of files touched in a ChangeLog entry.

Nit: Add a method?

> Tools/Scripts/webkitpy/common/checkout/changelog.py:78
> +    # e.g. * Source/WebCore/page/EventHandler.cpp: Implement FooBarQuux.
> +    touched_files_regexp = r'\s*\*\s*(?P<file>.+)\:'

Mn... files move every now and then so maybe we just want to partially match?  e.g. WebCore -> Source/WebCore.
Comment 3 Eric Seidel (no email) 2011-09-14 23:26:50 PDT
Comment on attachment 107390 [details]
Patch

This seems reasonable.
Comment 4 WebKit Review Bot 2011-09-20 09:30:22 PDT
Comment on attachment 107390 [details]
Patch

Clearing flags on attachment: 107390

Committed r95547: <http://trac.webkit.org/changeset/95547>
Comment 5 WebKit Review Bot 2011-09-20 09:30:27 PDT
All reviewed patches have been landed.  Closing bug.