RESOLVED FIXED 68225
[Chromium] Expose AXObjectCache methods so WebAccessibilityCache can be deleted. 
https://bugs.webkit.org/show_bug.cgi?id=68225
Summary [Chromium] Expose AXObjectCache methods so WebAccessibilityCache can be deleted.
Dominic Mazzoni
Reported 2011-09-15 23:30:37 PDT
WebAccessibilityCache is duplicating the functionality of AXObjectCache rather than replacing it. In addition, it's resulting in a subtle and confusing bug: because it uses a hash from pointer to ID, occasionally an object will be deleted, but another object will be allocated that coincidentally happens to get the same pointer address. When this happens, WebAccessibilityCache gives it the same ID, which can cause all sorts of anomalous behavior. This bug is to first add the necessary methods to wrap the existing AXObjectCache functionality needed. Then Chromium will be modified to use these methods instead of WebAccessibilityCache. Finally, we'll remove WebAccessibilityCache (https://bugs.webkit.org/show_bug.cgi?id=68224).
Attachments
Patch (5.67 KB, patch)
2011-09-15 23:37 PDT, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dominic Mazzoni
Comment 1 2011-09-15 23:37:18 PDT
Created attachment 107611 [details] Patch
WebKit Review Bot
Comment 2 2011-09-19 16:03:17 PDT
Comment on attachment 107611 [details] Patch Clearing flags on attachment: 107611 Committed r95491: <http://trac.webkit.org/changeset/95491>
WebKit Review Bot
Comment 3 2011-09-19 16:03:21 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.