Bug 68224 - [Chromium] Get rid of WebAccessibilityCache
Summary: [Chromium] Get rid of WebAccessibilityCache
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-15 23:28 PDT by Dominic Mazzoni
Modified: 2011-10-10 10:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (17.59 KB, patch)
2011-09-30 11:06 PDT, Dominic Mazzoni 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dominic Mazzoni 2011-09-15 23:28:20 PDT 
WebAccessibilityCache is duplicating the functionality of AXObjectCache rather than replacing it.

In addition, it's resulting in a subtle and confusing bug: because it uses a hash from pointer to ID, occasionally an object will be deleted, but another object will be allocated that coincidentally happens to get the same pointer address. When this happens, WebAccessibilityCache gives it the same ID, which can cause all sorts of anomalous behavior.

Strategy: first add the necessary methods to wrap the existing AXObjectCache functionality needed. Then remove WebAccessibilityCache.
Comment 1 Dominic Mazzoni 2011-09-30 11:06:10 PDT 
Created attachment 109315 [details]
Patch
Comment 2 Dominic Mazzoni 2011-09-30 11:07:59 PDT 
Comment on attachment 109315 [details]
Patch

Note: the changes to remove the dependency on WebAccessibilityCache landed in Chromium 24 hours ago. I edited WebKit.gyp and made sure that Chromium compiles.

Just double-checking, are there any other files I need to edit when removing source files from WebKit/chromium?
Comment 3 WebKit Review Bot 2011-10-10 10:23:32 PDT 
Comment on attachment 109315 [details]
Patch

Clearing flags on attachment: 109315

Committed r97068: <http://trac.webkit.org/changeset/97068>
Comment 4 WebKit Review Bot 2011-10-10 10:23:36 PDT 
All reviewed patches have been landed.  Closing bug.