Bug 67907 - Switch most calls in DFGJITCodeGenerator to use callOperation.
Summary: Switch most calls in DFGJITCodeGenerator to use callOperation.
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-11 14:15 PDT by Filip Pizlo
Modified: 2011-10-13 14:49 PDT (History)
2 users (show)

See Also:


Attachments
the patch (17.91 KB, patch)
2011-09-11 14:44 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-09-11 14:15:33 PDT
WTF has an idiom where C preprocessor macros that indicate whether or not a feature is enabled begin with the ENABLE_ prefix, and are queried using the ENABLE() macro.  DFGNode.h does not use this idiom, even though it should.
Comment 1 Filip Pizlo 2011-09-11 14:44:24 PDT
Created attachment 107009 [details]
the patch
Comment 2 Filip Pizlo 2011-09-11 15:46:21 PDT
Comment on attachment 107009 [details]
the patch

Tests pass, landing.
Comment 3 WebKit Review Bot 2011-09-11 20:41:47 PDT
Comment on attachment 107009 [details]
the patch

Clearing flags on attachment: 107009

Committed r94942: <http://trac.webkit.org/changeset/94942>
Comment 4 WebKit Review Bot 2011-09-11 20:41:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Gavin Barraclough 2011-10-13 14:49:26 PDT
This change was invalid, this will be fixed by https://bugs.webkit.org/show_bug.cgi?id=70060