The ENABLE macro is only intended to be used to detect features that are configured in Platform.h. Using its to detect settings defined in other headers is an error.
The problem is that the ENABLE macro checks if the value is defined, so will silently return false if you fail to include the header defining the switch.
This is not a problem if (1) the settings are defined in the same header that defines the macro that tests them, or (2) the header is included everywhere. In the case of ENABLE settings defined in Platform.h, both are true!
To make this clear, add an explicit DFG_ENABLE macro.
Created attachment 110913 [details]
Comment on attachment 110913 [details]
Attachment 110913 [details] did not pass style-queue:
Total errors found: 1 in 21 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Fixed in r97408