Bug 67849 - Chromium shadow-buffer-partial test change.
Summary: Chromium shadow-buffer-partial test change.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-09 08:21 PDT by bungeman
Modified: 2011-09-12 10:44 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.28 KB, patch)
2011-09-09 08:29 PDT, bungeman
no flags Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2011-09-12 06:28 PDT, bungeman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bungeman 2011-09-09 08:21:52 PDT
A skia change ( http://code.google.com/p/skia/source/detail?r=2211 ) fixes issues with clipped blurs. This fix is currently disabled in chromium. In order to enable this fix, the chromium test fast/box-shadow/ inset-box-shadow-radius and inset-box-shadows need to be updated, as they currently have an incorrect blur. This change will be to set these tests to be skipped. Once chromium rolls to skip the tests, the fix there (currently disabled) will be enabled. Then, after webkit rolls chromium past this change, there will be another webkit change to re-enable the tests. This is an extension to Bug 67724 as Bug 67596 (which went in yesterday right after Bug 67724 went in) re-enabled these two tests in test expectations.
Comment 1 bungeman 2011-09-09 08:29:58 PDT
Created attachment 106874 [details]
Patch
Comment 2 bungeman 2011-09-09 08:32:54 PDT
Adding reviewer. Note that this is an extension to Bug 67724, since Bug 67596 managed to make the blur change affect more tests.
Comment 3 Kenneth Russell 2011-09-09 14:54:59 PDT
Comment on attachment 106874 [details]
Patch

Unless the tests are crashing we should not skip running them, because then we won't see any really bad code changes that might make them actually crash. Just mark the expectations PASS FAIL.
Comment 4 bungeman 2011-09-12 06:28:22 PDT
Created attachment 107046 [details]
Patch
Comment 5 bungeman 2011-09-12 06:29:43 PDT
Comment on attachment 107046 [details]
Patch

Have changed tests from SKIP to just PASS FAIL.
Comment 6 Kenneth Russell 2011-09-12 09:43:49 PDT
Comment on attachment 107046 [details]
Patch

Looks fine. r=me
Comment 7 WebKit Review Bot 2011-09-12 10:44:33 PDT
Comment on attachment 107046 [details]
Patch

Clearing flags on attachment: 107046

Committed r94963: <http://trac.webkit.org/changeset/94963>
Comment 8 WebKit Review Bot 2011-09-12 10:44:39 PDT
All reviewed patches have been landed.  Closing bug.