Bug 67724 - Chromium shadow-buffer-partial test change.
Summary: Chromium shadow-buffer-partial test change.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-07 11:55 PDT by bungeman
Modified: 2011-09-08 14:15 PDT (History)
2 users (show)

See Also:


Attachments
Patch (10.67 KB, patch)
2011-09-07 12:07 PDT, bungeman
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description bungeman 2011-09-07 11:55:18 PDT
A skia change ( http://code.google.com/p/skia/source/detail?r=2211 ) fixes issues with clipped blurs. This fix is currently disabled in chromium. In order to enable this fix, the chromium test fast/box-shadow/shadow-buffer-partial needs to be updated, as it currently has an incorrect blur. This change will be to update the expected png and set the test to be skipped. Once chromium rolls to skip the test, the fix there (currently disabled) will be enabled. Then, after webkit rolls chromium past this change, there will be another webkit change to re-enable the test.
Comment 1 bungeman 2011-09-07 12:07:22 PDT
Created attachment 106619 [details]
Patch
Comment 2 bungeman 2011-09-08 06:05:13 PDT
Adding reviewer.
Comment 3 Kenneth Russell 2011-09-08 13:46:00 PDT
Comment on attachment 106619 [details]
Patch

Seems fine.
Comment 4 WebKit Review Bot 2011-09-08 14:15:36 PDT
Comment on attachment 106619 [details]
Patch

Clearing flags on attachment: 106619

Committed r94798: <http://trac.webkit.org/changeset/94798>
Comment 5 WebKit Review Bot 2011-09-08 14:15:40 PDT
All reviewed patches have been landed.  Closing bug.