[chromium] REGRESSION(94353): Compositor textures and resources leaked when tab closed that is not last tab in the process
Created attachment 106810 [details]
This fixes the leak, but I really really really want to get some automated tests for this before landed. I left the OOPS! in the changelog to remind myself. I've fixed this bug twice and don't really want to have to do it again :/
Note that this is another sign that https://bugs.webkit.org/show_bug.cgi?id=66995 is something we need, the problem here is our overuse of RefPtr<>s which needs lots of manual cleanup.
Comment on attachment 106810 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=106810&action=review
Looks fine to me. ChangeLog needs a small cleanup before landing.
> + No new tests. (OOPS!)
That OOPS needs to be removed.
Thanks Ken. We need this patch for 15 so I'll clean up the ChangeLog and continue to work on testing infrastructure.
Committed r94964: <http://trac.webkit.org/changeset/94964>