Remove the Completion object from JSC, I have never liked it
Created attachment 106694 [details] Patch
Let's see windows crash and burn :(.
Attachment 106694 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 106694 [details] Patch Attachment 106694 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9609827
Comment on attachment 106694 [details] Patch Attachment 106694 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9616053
Comment on attachment 106694 [details] Patch Attachment 106694 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/9616108
Created attachment 106747 [details] Patch
Attachment 106747 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 106748 [details] Patch
Attachment 106748 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 106761 [details] Patch
Attachment 106761 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 106780 [details] Patch
Attachment 106780 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:66: One line control clauses should not use braces. [whitespace/braces] [4] Source/JavaScriptCore/runtime/Completion.cpp:83: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 4 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 106794 [details] Patch
Attachment 106794 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/API/JSBase.cpp', u'S..." exit_code: 1 Source/JavaScriptGlue/JavaScriptGlue.cpp:314: An else should appear on the same line as the preceding } [whitespace/newline] [4] Source/JavaScriptGlue/JavaScriptGlue.cpp:315: This { should be at the end of the previous line [whitespace/braces] [4] Total errors found: 2 in 31 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 106794 [details] Patch It would be nice if the inherits checks moved into helper functions (e.g. isTerminatedExecutionError()), and also if thoses classes move out of ExceptionHelpers at some point.
Committed r94811: <http://trac.webkit.org/changeset/94811>
This patch caused two worker tests to hit assertions. See the bug 67829.
(In reply to comment #19) > This patch caused two worker tests to hit assertions. See the bug 67829. Thanks, I will take a look ASAP.