Implement double tap detection in GestureRecognizerChromium
Created attachment 106585 [details] Patch
*** Bug 67708 has been marked as a duplicate of this bug. ***
Comment on attachment 106585 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106585&action=review LGTM. But you should update the patch for the intended order of committing. > Source/WebCore/platform/PlatformGestureEvent.h:42 > + DoubleTapType, this cl will not merge clean with the other one. In particular, the unit tests will fail. You should pick an order of committing and write one patch as a dependency of the other
Created attachment 106621 [details] Patch
(In reply to comment #3) > (From update of attachment 106585 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=106585&action=review > > LGTM. But you should update the patch for the intended order of committing. > > > Source/WebCore/platform/PlatformGestureEvent.h:42 > > + DoubleTapType, > > this cl will not merge clean with the other one. In particular, the unit tests will fail. You should pick an order of committing and write one patch as a dependency of the other Merged the other CL.
Created attachment 106622 [details] Patch
Missed the Changelog in previous patch. Uploaded new one.. PTAL
Created attachment 106771 [details] Patch
Comment on attachment 106771 [details] Patch Clearing flags on attachment: 106771 Committed r94797: <http://trac.webkit.org/changeset/94797>
All reviewed patches have been landed. Closing bug.