Bug 67709 - Implement double tap detection in GestureRecognizerChromium
: Implement double tap detection in GestureRecognizerChromium
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To: Nobody
:
Depends on: 67645
Blocks:
  Show dependency treegraph
 
Reported: 2011-09-07 08:13 PDT by Varun Jain
Modified: 2011-09-08 14:10 PDT (History)
3 users (show)

See Also:


Attachments
Patch (14.96 KB, patch)
2011-09-07 08:14 PDT, Varun Jain
no flags Details | Formatted Diff | Diff
Patch (14.78 KB, patch)
2011-09-07 12:49 PDT, Varun Jain
no flags Details | Formatted Diff | Diff
Patch (15.42 KB, patch)
2011-09-07 12:57 PDT, Varun Jain
no flags Details | Formatted Diff | Diff
Patch (15.57 KB, patch)
2011-09-08 11:57 PDT, Varun Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Varun Jain 2011-09-07 08:13:56 PDT
Implement double tap detection in GestureRecognizerChromium
Comment 1 Varun Jain 2011-09-07 08:14:41 PDT
Created attachment 106585 [details]
Patch
Comment 2 Varun Jain 2011-09-07 08:15:54 PDT
*** Bug 67708 has been marked as a duplicate of this bug. ***
Comment 3 Robert Kroeger 2011-09-07 11:16:47 PDT
Comment on attachment 106585 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=106585&action=review

LGTM. But you should update the patch for the intended order of committing.

> Source/WebCore/platform/PlatformGestureEvent.h:42
> +        DoubleTapType,

this cl will not merge clean with the other one. In particular, the unit tests will fail. You should pick an order of committing and write one patch as a dependency of the other
Comment 4 Varun Jain 2011-09-07 12:49:13 PDT
Created attachment 106621 [details]
Patch
Comment 5 Varun Jain 2011-09-07 12:55:21 PDT
(In reply to comment #3)
> (From update of attachment 106585 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=106585&action=review
> 
> LGTM. But you should update the patch for the intended order of committing.
> 
> > Source/WebCore/platform/PlatformGestureEvent.h:42
> > +        DoubleTapType,
> 
> this cl will not merge clean with the other one. In particular, the unit tests will fail. You should pick an order of committing and write one patch as a dependency of the other

Merged the other CL.
Comment 6 Varun Jain 2011-09-07 12:57:41 PDT
Created attachment 106622 [details]
Patch
Comment 7 Varun Jain 2011-09-07 12:59:22 PDT
Missed the Changelog in previous patch. Uploaded new one..  PTAL
Comment 8 Varun Jain 2011-09-08 11:57:05 PDT
Created attachment 106771 [details]
Patch
Comment 9 WebKit Review Bot 2011-09-08 14:10:50 PDT
Comment on attachment 106771 [details]
Patch

Clearing flags on attachment: 106771

Committed r94797: <http://trac.webkit.org/changeset/94797>
Comment 10 WebKit Review Bot 2011-09-08 14:10:54 PDT
All reviewed patches have been landed.  Closing bug.