Bug 67580 – POTFILES.in/.skip need updates for translators

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Andre Klapper]

http://l10n.gnome.org/module/webkit/ lists quite some issues with /po/POTFILES.in/.skip that block creating an up-to-date translation template and hence create an unneeded burden for translation contributors.

[Chris Leonard]

This really does need to be addressed.

[Chris Leonard]

This ticket is blocking for the following:

https://bugzilla.gnome.org/show_bug.cgi?id=610165
https://bugzilla.gnome.org/show_bug.cgi?id=610164
https://bugzilla.gnome.org/show_bug.cgi?id=610163
https://bugzilla.gnome.org/show_bug.cgi?id=610162
https://bugzilla.gnome.org/show_bug.cgi?id=610161
https://bugzilla.gnome.org/show_bug.cgi?id=610160
https://bugzilla.gnome.org/show_bug.cgi?id=610159
https://bugzilla.gnome.org/show_bug.cgi?id=610158
https://bugzilla.gnome.org/show_bug.cgi?id=610155
https://bugzilla.gnome.org/show_bug.cgi?id=610153
https://bugzilla.gnome.org/show_bug.cgi?id=610151
https://bugzilla.gnome.org/show_bug.cgi?id=610150
https://bugzilla.gnome.org/show_bug.cgi?id=610149
https://bugzilla.gnome.org/show_bug.cgi?id=610147
https://bugzilla.gnome.org/show_bug.cgi?id=610146
https://bugzilla.gnome.org/show_bug.cgi?id=610145
https://bugzilla.gnome.org/show_bug.cgi?id=610144
https://bugzilla.gnome.org/show_bug.cgi?id=610142
https://bugzilla.gnome.org/show_bug.cgi?id=610139
https://bugzilla.gnome.org/show_bug.cgi?id=610138
https://bugzilla.gnome.org/show_bug.cgi?id=610135
https://bugzilla.gnome.org/show_bug.cgi?id=610129
https://bugzilla.gnome.org/show_bug.cgi?id=610128
https://bugzilla.gnome.org/show_bug.cgi?id=610125
https://bugzilla.gnome.org/show_bug.cgi?id=610120
https://bugzilla.gnome.org/show_bug.cgi?id=610118
https://bugzilla.gnome.org/show_bug.cgi?id=610115
https://bugzilla.gnome.org/show_bug.cgi?id=610113
https://bugzilla.gnome.org/show_bug.cgi?id=610112
https://bugzilla.gnome.org/show_bug.cgi?id=610111
https://bugzilla.gnome.org/show_bug.cgi?id=610110
https://bugzilla.gnome.org/show_bug.cgi?id=610109
https://bugzilla.gnome.org/show_bug.cgi?id=610106
https://bugzilla.gnome.org/show_bug.cgi?id=610103
https://bugzilla.gnome.org/show_bug.cgi?id=610102
https://bugzilla.gnome.org/show_bug.cgi?id=610095
https://bugzilla.gnome.org/show_bug.cgi?id=610094

[Andre Klapper]

So who do I need to talk to here? 
Currently this makes the Epiphany browser on GNOME look rather untranslated.

[Chris Leonard]

I think this bug is blocked by 

https://bugs.webkit.org/show_bug.cgi?id=45321

I've been trying to get something done about it, with no success so far.

I did get Martin Robinson (webkitgtk+) talking to Claude Paroz (gnome-18n) two weeks ago , to see about a hackish fix, like the symlink one mentioned in that bug, but that conversation has gone quiet since.

[Martin Robinson]

The first step is to fix the list of files in POTFILES (and move it to POTFILES.in for the sake of intltool). The second step is to fix intltoool-update -m, which requires changes to intltools. I think that should be enough to get Damned Lies working. If not, it should get us closer.

[Martin Robinson]

Created attachment 169787 [details]
Patch

[Xan Lopez]

Comment on attachment 169787 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=169787&action=review

> Source/WebKit/gtk/po/GNUmakefile.am:72
> +$(DOMAIN).pot-update: $(POTFILES) Source/WebKit/gtk/po/POTFILES

Don't we want top_builddir here? Or does it have to be absolutely nothing.

> Source/WebKit/gtk/po/GNUmakefile.am:87
> +	        --files-from=Source/WebKit/gtk/po/POTFILES \

Same question.

> Source/WebKit/gtk/po/GNUmakefile.am:100
> +	        --files-from=Source/WebKit/gtk/po/POTFILES \

And same.

[Martin Robinson]

(In reply to comment #7)
> (From update of attachment 169787 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=169787&action=review
> 
> > Source/WebKit/gtk/po/GNUmakefile.am:72
> > +$(DOMAIN).pot-update: $(POTFILES) Source/WebKit/gtk/po/POTFILES
> 
> Don't we want top_builddir here? Or does it have to be absolutely nothing.

The build directory will always be the current directory, I believe. We make that assumption in other places, so I think we're safe omitting $(top_builddir).

[Xan Lopez]

Comment on attachment 169787 [details]
Patch

Still seems safer to put the variable there; it works now but we might change the build system somehow and it would stop. Good practice to make assumptions explicit! Anyway, r+, you can change before landing.

[Martin Robinson]

Committed r132289: <http://trac.webkit.org/changeset/132289>

*** Bug 45321 has been marked as a duplicate of this bug. ***

[Martin Robinson]

*** Bug 81969 has been marked as a duplicate of this bug. ***