Bug 67421 - HTMLMediaElement should use fastHasAttribute instead of hasAttribute
Summary: HTMLMediaElement should use fastHasAttribute instead of hasAttribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-09-01 11:44 PDT by Eric Carlson
Modified: 2011-09-01 14:21 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch (3.82 KB, patch)
2011-09-01 11:52 PDT, Eric Carlson 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-09-01 11:44:47 PDT 
As noted in the review of https://bugs.webkit.org/show_bug.cgi?id=58369, when HTMLMediaElement checks attribute values style attributes and SVG animated attributes are not involved so it would be faster to use fastHasAttribute instead of hasAttribute.
Comment 1 Radar WebKit Bug Importer 2011-09-01 11:45:49 PDT 
<rdar://problem/10061390>
Comment 2 Eric Carlson 2011-09-01 11:52:35 PDT 
Created attachment 105999 [details]
Proposed patch
Comment 3 Simon Fraser (smfr) 2011-09-01 14:08:46 PDT 
Comment on attachment 105999 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105999&action=review

> Source/WebCore/ChangeLog:8
> +        No new tests required, this is just an optimization.

It would be nice if your change log explained why it's better, for those of us following along.
Comment 4 Eric Carlson 2011-09-01 14:21:57 PDT 
http://trac.webkit.org/changeset/94344