Bug 58369 – Add 'muted' content attribute to HTMLMediaElement

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

http://html5.org/tools/web-apps-tracker?from=5990&to=5991 added a 'muted' content attribute.

[Eric Carlson]

Created attachment 105981 [details]
Proposed patch

[Radar WebKit Bug Importer]

<rdar://problem/10060343>

[Darin Adler]

Comment on attachment 105981 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105981&action=review

> Source/WebCore/html/HTMLMediaElement.idl:81
> +    attribute boolean defaultMuted;

If you wrote this:

    attribute [Reflect=muted] boolean defaultMuted;

Then you would not need to add the HTMLMediaElement::defaultMuted and HTMLMediaElement::setDefaultMuted functions. How about doing it that way?

[Darin Adler]

Comment on attachment 105981 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105981&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:812
> +    if (hasAttribute(mutedAttr))

This can be fastHasAttribute since style attributes and SVG animated attributes are not involved. Faster.

[Eric Carlson]

(In reply to comment #3)
> (From update of attachment 105981 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105981&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.idl:81
> > +    attribute boolean defaultMuted;
> 
> If you wrote this:
> 
>     attribute [Reflect=muted] boolean defaultMuted;
> 
> Then you would not need to add the HTMLMediaElement::defaultMuted and HTMLMediaElement::setDefaultMuted functions. How about doing it that way?

Good suggestion, thanks!


(In reply to comment #4)
> (From update of attachment 105981 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=105981&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:812
> > +    if (hasAttribute(mutedAttr))
> 
> This can be fastHasAttribute since style attributes and SVG animated attributes are not involved. Faster.

Another good suggestion, unfortunately I missed it before I submitted. I will fix this in a follow-up patch.

[Eric Carlson]

 https://bugs.webkit.org/show_bug.cgi?id=58369

[Eric Carlson]

With the correct url this time: http://trac.webkit.org/changeset/94318