Element::recalcStyle() does not need to be virtual, there are very few legit overrides. This will also make it possible to de-recursify it later.
Created attachment 105930 [details] patch
Comment on attachment 105930 [details] patch this looks glorious. Your change highlights the greater problem of hacks around style recalculation. Adding those extra methods (and stealing a bit) from Node.h is a great motivator to fix this problem for realz. But... why are the EWS chipmunks so purple?
Created attachment 106105 [details] tot patch for bots to chew
Attachment 106105 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/svg/SVGUseElement.h:67: The parameter name "change" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/svg/SVGUseElement.h:68: The parameter name "change" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 106105 [details] tot patch for bots to chew Attachment 106105 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9582601 New failing tests: svg/batik/text/textStyles.svg
http://trac.webkit.org/changeset/94406
Couldn't see the bot reported test failure locally.
Folloup in bug 67480