Bug 67378 - De-virtualize recalcStyle()
Summary: De-virtualize recalcStyle()
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2011-09-01 01:59 PDT by Antti Koivisto
Modified: 2011-09-02 06:05 PDT (History)
5 users (show)

See Also:

patch (25.66 KB, patch)
2011-09-01 02:49 PDT, Antti Koivisto
dglazkov: review+
Details | Formatted Diff | Diff
tot patch for bots to chew (26.06 KB, patch)
2011-09-02 02:02 PDT, Antti Koivisto
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2011-09-01 01:59:54 PDT
Element::recalcStyle() does not need to be virtual, there are very few legit overrides. This will also make it possible to de-recursify it later.
Comment 1 Antti Koivisto 2011-09-01 02:49:02 PDT
Created attachment 105930 [details]
Comment 2 Dimitri Glazkov (Google) 2011-09-01 08:57:59 PDT
Comment on attachment 105930 [details]

this looks glorious. Your change highlights the greater problem of hacks around style recalculation. Adding those extra methods (and stealing a bit) from Node.h is a great motivator to fix this problem for realz. But... why are the EWS chipmunks so purple?
Comment 3 Antti Koivisto 2011-09-02 02:02:41 PDT
Created attachment 106105 [details]
tot patch for bots to chew
Comment 4 WebKit Review Bot 2011-09-02 02:05:47 PDT
Attachment 106105 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/svg/SVGUseElement.h:67:  The parameter name "change" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/WebCore/svg/SVGUseElement.h:68:  The parameter name "change" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 23 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 WebKit Review Bot 2011-09-02 02:50:32 PDT
Comment on attachment 106105 [details]
tot patch for bots to chew

Attachment 106105 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9582601

New failing tests:
Comment 6 Antti Koivisto 2011-09-02 04:19:22 PDT
Comment 7 Antti Koivisto 2011-09-02 04:19:56 PDT
Couldn't see the bot reported test failure locally.
Comment 8 Antti Koivisto 2011-09-02 06:05:24 PDT
Folloup in bug 67480