Bug 67267 - Remove closeColorChooser call from FrameLoader::transitionToCommitted
Summary: Remove closeColorChooser call from FrameLoader::transitionToCommitted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 00:47 PDT by Keishi Hattori
Modified: 2011-08-31 18:55 PDT (History)
3 users (show)

See Also:

Attachments
patch (3.62 KB, patch)
2011-08-31 01:14 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
added reason in changelog (3.68 KB, patch)
2011-08-31 18:25 PDT, Keishi Hattori 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2011-08-31 00:47:12 PDT 
It was a bad place to put it. Discussed in Bug 66843
We don't need this for the chromium port.
Comment 1 Keishi Hattori 2011-08-31 01:14:43 PDT 
Created attachment 105757 [details]
patch
Comment 2 Kent Tamura 2011-08-31 01:22:20 PDT 
Comment on attachment 105757 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105757&action=review

> Source/WebCore/ChangeLog:5
> +        Remove closeColorChooser call from FrameLoader::transitionToCommitted
> +        https://bugs.webkit.org/show_bug.cgi?id=67267
> +

You should write reasons of the removal in ChangeLog.
Comment 3 Keishi Hattori 2011-08-31 18:25:23 PDT 
Created attachment 105875 [details]
added reason in changelog
Comment 4 WebKit Review Bot 2011-08-31 18:55:43 PDT 
Comment on attachment 105875 [details]
added reason in changelog

Clearing flags on attachment: 105875

Committed r94264: <http://trac.webkit.org/changeset/94264>
Comment 5 WebKit Review Bot 2011-08-31 18:55:47 PDT 
All reviewed patches have been landed.  Closing bug.