Bug 66843 - Color chooser closes on "open new tab"
Summary: Color chooser closes on "open new tab"
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-24 01:55 PDT by Keishi Hattori
Modified: 2011-09-06 15:42 PDT (History)
0 users

See Also:


Attachments
patch (3.51 KB, patch)
2011-08-24 03:43 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2011-08-24 01:55:51 PDT
Color chooser closes on "open new tab" and "open Web Inspector".

I caused this bug while solving the layer violation in Bug 62619.
Comment 1 Keishi Hattori 2011-08-24 03:43:59 PDT
Created attachment 104978 [details]
patch
Comment 2 Darin Adler 2011-08-24 09:48:50 PDT
Comment on attachment 104978 [details]
patch

Not a comment about this patch, but about the original code.

This seems like bad encapsulation. transitionToCommitted in the loader does not seem like the right place to be directly manipulating UI; there is no other code like that in there.

On a separate note, this implements a UI policy that is not universal; this is not how color panels work on Macs. Closing the window that you used to trigger the color panel does not make it go away.
Comment 3 Keishi Hattori 2011-08-25 05:40:55 PDT
> On a separate note, this implements a UI policy that is not universal; this is not how color panels work on Macs. Closing the window that you used to trigger the color panel does not make it go away.

You are absolutely right. I will abandon this idea to close the color panel when the element disappears for OS X.

> This seems like bad encapsulation. transitionToCommitted in the loader does not seem like the right place to be directly manipulating UI; there is no other code like that in there.

I knew it was wrong but transitionToCommitted was the only place I could find. I will remove these lines immediately in an upcoming patch.

I will close this bug as it is no longer relavent.

Thanks for taking a look!
Comment 4 Eric Seidel (no email) 2011-09-06 15:42:03 PDT
Comment on attachment 104978 [details]
patch

Cleared review? from attachment 104978 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).