Bug 67179 – [chromium] Allow GraphicsContexts to be created from MockWebGraphicsContexts

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nat Duca]

[chromium] Allow GraphicsContexts to be created from MockWebGraphicsContexts

[Nat Duca]

Created attachment 105579 [details]
Patch

[Nat Duca]

@kbr, I'd love any feedback you have on the overall structure here. I'm absolutely fine trying a totally different approach than this --- I just took a stab in the dark at this one.

[Kenneth Russell]

Comment on attachment 105579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=105579&action=review

Looks good overall. This one will have to be merged with the fix for https://bugs.webkit.org/show_bug.cgi?id=67172 which just landed. Couple of minor comments. I'll r+ this in case you want to fix the issues upon landing, or feel free to upload another version.

> Source/WebKit/chromium/src/GraphicsContext3DChromium.cpp:120
> +PassRefPtr<GraphicsContext3D> GraphicsContext3DInternal::createFromWebContext(PassOwnPtr<WebKit::WebGraphicsContext3D> webContext, GraphicsContext3D::Attributes attrs, HostWindow* hostWindow, GraphicsContext3D::RenderStyle renderStyle)

This is clearly the key method. I see that there's really no other place to put it (can't go in GC3D, because that can't reference our WebKit API). However could you perhaps name it something like createGraphicsContext3DFromWebContext to avoid confusion?

> Source/WebKit/chromium/src/GraphicsContext3DInternal.h:59
> +    static PassRefPtr<GraphicsContext3D> createFromWebContext(PassOwnPtr<WebKit::WebGraphicsContext3D>, GraphicsContext3D::Attributes, HostWindow*, GraphicsContext3D::RenderStyle);

Could you indicate that the createFromWebContext method (or whatever it ends up being called) is only for testing purposes?

[Nat Duca]

Created attachment 105668 [details]
Patch for landing

[WebKit Review Bot]

Comment on attachment 105668 [details]
Patch for landing

Clearing flags on attachment: 105668

Committed r94106: <http://trac.webkit.org/changeset/94106>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Alexander Pavlov (apavlov)]

The landed patch breaks at least gclient:
"Error: Missing input file src\third_party\WebKit\Source\WebKit\chromium\tests\MockGraphicsContext3D.h"
as it includes a new file 'tests/MockGraphicsContext3D.h' which is not added by the patch. I have filed bug 67288 to track this issue.