Bug 67288 - [Chromium] Inconsistent WebKit.gypi after r94106
Summary: [Chromium] Inconsistent WebKit.gypi after r94106
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: Nat Duca
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-31 06:23 PDT by Alexander Pavlov (apavlov)
Modified: 2011-09-06 15:43 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.18 KB, patch)
2011-08-31 09:55 PDT, Nat Duca
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Pavlov (apavlov) 2011-08-31 06:23:11 PDT
The patch r94106 breaks at least gclient on Windows:
"Error: Missing input file src\third_party\WebKit\Source\WebKit\chromium\tests\MockGraphicsContext3D.h"
since WebKit.gypi includes a new file 'tests/MockGraphicsContext3D.h' not added by the patch.
Comment 1 Nat Duca 2011-08-31 09:55:58 PDT
Created attachment 105784 [details]
Patch
Comment 2 Nat Duca 2011-08-31 10:20:12 PDT
Committed r94199: <http://trac.webkit.org/changeset/94199>
Comment 3 Eric Seidel (no email) 2011-09-06 15:43:54 PDT
Comment on attachment 105784 [details]
Patch

Cleared review? from attachment 105784 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).