Follow-up to https://bugs.webkit.org/show_bug.cgi?id=63301. We have long lists of booleans that get passed all around and are easy to get wrong. They'd be more readable as enums. I'm targeting sendLoadCallbacks, sniffContent, and shoulBufferData in ResourceLoaderOptions, and allowCredentials in ThreadableLoaderOptions.
Created attachment 105252 [details] patch
Comment on attachment 105252 [details] patch Attachment 105252 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9508591
Created attachment 105260 [details] Update Notification.cpp too
Comment on attachment 105260 [details] Update Notification.cpp too View in context: https://bugs.webkit.org/attachment.cgi?id=105260&action=review > Source/WebCore/loader/cache/CachedResourceRequest.cpp:128 > + ResourceLoaderOptions(sendResourceLoadCallbacks ? SendCallbacks : DoNotSendCallbacks, SniffContent, BufferData)); You may want to consider making this function take the enum instead of a bool.
Comment on attachment 105260 [details] Update Notification.cpp too Attachment 105260 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9507684
Comment on attachment 105260 [details] Update Notification.cpp too Attachment 105260 [details] did not pass cr-mac-ews (chromium): Output: http://queues.webkit.org/results/9495842
(In reply to comment #4) > (From update of attachment 105260 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=105260&action=review > > > Source/WebCore/loader/cache/CachedResourceRequest.cpp:128 > > + ResourceLoaderOptions(sendResourceLoadCallbacks ? SendCallbacks : DoNotSendCallbacks, SniffContent, BufferData)); > > You may want to consider making this function take the enum instead of a bool. I'm going to do that as a part of my next attempt at https://bugs.webkit.org/show_bug.cgi?id=66018.
Created attachment 105363 [details] Patch for landing
Comment on attachment 105363 [details] Patch for landing Clearing flags on attachment: 105363 Committed r93886: <http://trac.webkit.org/changeset/93886>
All reviewed patches have been landed. Closing bug.