Bug 66500 - [Qt] editing/selection/regional-indicators.html fails
Summary: [Qt] editing/selection/regional-indicators.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rafael Brandao
URL:
Keywords:
Depends on: 76821 77102
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-18 14:50 PDT by Alexey Proskuryakov
Modified: 2012-02-01 12:29 PST (History)
4 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2012-01-17 05:07 PST, Rafael Brandao
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2011-08-18 14:50:01 PDT
Non-ICU ports do not have any logic for regional indicator symbols. See bug 65395.
Comment 1 Alexey Proskuryakov 2011-08-18 14:51:21 PDT
Landed failing results in r93351.
Comment 2 Rafael Brandao 2012-01-17 05:04:04 PST
$ ./Tools/Scripts/run-webkit-tests --release --qt --iterations=100 LayoutTests/editing/selection/regional-indicators.html
Running new-run-webkit-tests with one child process.
For more parallelism, run new-run-webkit-tests directly.
                                                       
100 tests ran as expected (-99 didn't run).


I'll remove this from skipped list as it is passing now.
Comment 3 Rafael Brandao 2012-01-17 05:07:06 PST
Created attachment 122752 [details]
Patch
Comment 4 Csaba Osztrogonác 2012-01-17 06:21:44 PST
(In reply to comment #2)
> $ ./Tools/Scripts/run-webkit-tests --release --qt --iterations=100 LayoutTests/editing/selection/regional-indicators.html
> Running new-run-webkit-tests with one child process.
> For more parallelism, run new-run-webkit-tests directly.
> 
> 100 tests ran as expected (-99 didn't run).
> 
> 
> I'll remove this from skipped list as it is passing now.

No, it doesn't pass, it still fails. The script said that we get same result as the committed false expected file (r93351).
Comment 5 Csaba Osztrogonác 2012-01-17 06:23:39 PST
Comment on attachment 122752 [details]
Patch

We can remove it from skipped list, but we should leave this bug open, because this test still fails.
Comment 6 Csaba Osztrogonác 2012-01-17 06:31:42 PST
Comment on attachment 122752 [details]
Patch

Clearing flags on attachment: 122752

Committed r105149: <http://trac.webkit.org/changeset/105149>
Comment 7 Csaba Osztrogonác 2012-01-17 06:31:50 PST
All reviewed patches have been landed.  Closing bug.
Comment 8 Alexey Proskuryakov 2012-01-17 08:52:13 PST
Re-opening per comment 5.
Comment 9 Balazs Kelemen 2012-01-26 07:24:16 PST
It's still failing. See: https://bugs.webkit.org/show_bug.cgi?id=77102
Comment 10 Rafael Brandao 2012-02-01 12:29:03 PST
This is now working after r105997, without those false expected files. Closing it.