Bug 66445 - Fix logic error causing reverse of desired WebGL rate limiting behavior
Summary: Fix logic error causing reverse of desired WebGL rate limiting behavior
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-17 18:56 PDT by John Bates
Modified: 2011-08-22 18:09 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.69 KB, patch)
2011-08-17 18:56 PDT, John Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Bates 2011-08-17 18:56:12 PDT 
Fix logic error causing reverse of desired WebGL rate limiting behavior
Comment 1 John Bates 2011-08-17 18:56:49 PDT 
Created attachment 104294 [details]
Patch
Comment 2 John Bates 2011-08-17 18:58:08 PDT 
Quick fix...
Comment 3 Kenneth Russell 2011-08-18 11:32:54 PDT 
Comment on attachment 104294 [details]
Patch

Looks good.
Comment 4 WebKit Review Bot 2011-08-18 12:32:26 PDT 
Comment on attachment 104294 [details]
Patch

Clearing flags on attachment: 104294

Committed r93335: <http://trac.webkit.org/changeset/93335>
Comment 5 WebKit Review Bot 2011-08-18 12:32:30 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Darin Adler 2011-08-18 12:33:00 PDT 
Is there a way to make a regression test for this?
Comment 7 Kenneth Russell 2011-08-18 14:35:33 PDT 
(In reply to comment #6)
> Is there a way to make a regression test for this?

We gave this some thought; this fix would probably be testable with more hooks in the LayoutTestController. (Run an animation, do some WebGL work, and ensure that it isn't being rate-limited.) John, would you consider filing another bug to add a regression test in this area?
Comment 8 John Bates 2011-08-22 18:09:34 PDT 
Filed: https://bugs.webkit.org/show_bug.cgi?id=66742