Bug 66442 - [skia] -webkit-transform breaks -webkit-mask
Summary: [skia] -webkit-transform breaks -webkit-mask
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ben Wells
Depends on:
Reported: 2011-08-17 18:15 PDT by Ben Wells
Modified: 2011-08-18 21:51 PDT (History)
6 users (show)

See Also:

Patch (17.50 KB, patch)
2011-08-17 19:07 PDT, Ben Wells
no flags Details | Formatted Diff | Diff
Test case from crbug.com (313 bytes, text/html)
2011-08-17 19:09 PDT, Ben Wells
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Wells 2011-08-17 18:15:38 PDT
See attachment. This works in mac chrome (and presumably safari, although -webkit-linear-transform is pretty new so I can't test), but not windows or linux chrome. (This report is also reported at http://crbug.com/81478.)
Comment 1 Ben Wells 2011-08-17 19:07:33 PDT
Created attachment 104296 [details]
Comment 2 Ben Wells 2011-08-17 19:09:38 PDT
Created attachment 104297 [details]
Test case from crbug.com
Comment 3 Stephen White 2011-08-18 04:42:23 PDT
This looks good, but have you run the full layout test suite?  Does this patch will change any results on other tests (hopefully for the better)?  For example, I'm wondering if this may be why our SVG masks results are wrong, e.g., crbug.com/3244.
Comment 4 Ben Wells 2011-08-18 16:46:24 PDT
I have run all the tests and there is no difference. SVG tests in particular seem to be equally broken, there is no improvement for the testcases on webkit bug 64237 or bug 44278, or for http://crbug.com/3244.

I think the svg stuff might do the masking in other ways and have other problems. Looking at WebCore/rendering/svg/SVGImageBufferTools.cpp SVGImageBufferTools::renderSubtreeToImageBuffer it uses context.clipToImageBuffer (which seems to be used for bug 642367). I haven't investigated SVG further than this.

There could be some other new non-svg passes which are hidden by font or other platform differences - I only noticed the transformed-mask.html included in the patch by accident when going to add a new test that had a similar name.

I just generated a list of tests which are marked as fails which have webkit-mask or webkit-transform, there is quite a few but I'll check them out to see if we've got any new passes.
Comment 5 Stephen White 2011-08-18 20:50:23 PDT
Comment on attachment 104296 [details]

Looks good.  Mike Reed should probably take a look at this when he gets back.  r=me
Comment 6 Ben Wells 2011-08-18 21:06:41 PDT
Thanks for the review. I found two more tests which should pass, I'll rebaseline them once this has landed and had time to generate some results.
Comment 7 WebKit Review Bot 2011-08-18 21:51:51 PDT
Comment on attachment 104296 [details]

Clearing flags on attachment: 104296

Committed r93386: <http://trac.webkit.org/changeset/93386>
Comment 8 WebKit Review Bot 2011-08-18 21:51:56 PDT
All reviewed patches have been landed.  Closing bug.