Bug 44278 - chromium windows + linux svg tests failing after r65665
Summary: chromium windows + linux svg tests failing after r65665
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-08-19 11:23 PDT by John Gregg
Modified: 2012-04-12 14:10 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Gregg 2010-08-19 11:23:26 PDT
http://trac.webkit.org/changeset/65665/ caused some regressions in chromium layout tests on windows and linux

  svg/batik/paints/patternRegions-positioned-objects.svg = IMAGE+TEXT
  svg/custom/pattern-incorrect-tiling.svg = IMAGE+TEXT
  svg/transforms/text-with-mask-with-svg-transform.svg = IMAGE+TEXT
  svg/batik/paints/patternRegions.svg = IMAGE
  svg/custom/js-late-pattern-and-object-creation.svg = IMAGE
  svg/custom/js-late-pattern-creation.svg = IMAGE
  svg/custom/non-scaling-stroke.svg = IMAGE
  svg/custom/pattern-no-pixelation.svg = IMAGE
  svg/custom/stroked-pattern.svg = IMAGE
Comment 1 John Gregg 2010-08-19 11:45:44 PDT
Committed r65687: <http://trac.webkit.org/changeset/65687>
Comment 2 John Gregg 2010-08-19 11:47:13 PDT
that patch was just the failing test expectations. bug isn't fixed yet
Comment 3 Nikolas Zimmermann 2010-08-19 23:56:34 PDT
(In reply to comment #2)
> that patch was just the failing test expectations. bug isn't fixed yet

Hi John,

can you point me to the failing test results? I need to have a look at them.
Comment 4 John Gregg 2010-08-20 09:41:21 PDT
Sure, this page should contain show you all the expected results and the actual ones.  Let me know if you can't access it or find the information you need.

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&useWebKitCanary=true&tests=svg%2Fclip-path%2Fclip-path-pixelation.svg%2Csvg%2Fbatik%2Ftext%2FtextProperties.svg%2Csvg%2Fclip-path%2Fclip-path-childs-clipped.svg

I'm not an SVG expert, and some of these probably just need new baselines, but i'm pretty sure that at least
svg/transforms/text-with-mask-with-svg-transform.svg
svg/custom/stroked-pattern.svg
are wrong.

Thanks!
Comment 5 Nikolas Zimmermann 2010-08-22 03:40:59 PDT
(In reply to comment #4)
> svg/transforms/text-with-mask-with-svg-transform.svg
Bug 41428 will contain a speculative fix for masks, please try afterwards.

> svg/custom/stroked-pattern.svg
This result looks correct, the comment in the test is wrong, I should fix it.
The mac baseline and the chromium baselines looks the same to me?

Cheers,
Niko
Comment 6 Stephen Chenney 2012-04-12 14:10:18 PDT
Committed r114033: <http://trac.webkit.org/changeset/114033>