Bug 66350 - Should call didFail for nil requests
Summary: Should call didFail for nil requests
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 66336
Blocks: 51836
  Show dependency tree / graph
 
Reported: 2011-08-16 16:48 PDT by Pratik Solanki
Modified: 2011-08-17 12:08 PDT (History)
5 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2011-08-16 16:48:06 PDT 
PolicyChecker::checkNavigationPolicy() tries to avoid making a delegate callback if the request is null. It does

    if (equalIgnoringHeaderFields(request, loader->lastCheckedRequest()) || (!request.isNull() && request.url().isEmpty())) {
        function(argument, request, 0, true);
        loader->setLastCheckedRequest(request);
        return;
    }

However, if the request is null i.e. a caller called [WebFrame loadRequest:nil], we should at least make a did fail notification to inform the caller. This can be done by just calling PolicyChecker::continueAfterNavigationPolicy(PolicyUse). The checks in that code will trigger the didFail notification.

We do get a didFail notification on mac right now. But that's because of bug 66336. If we fix that, we won't get the failure notification. This bug occurs when we use the CFNetwork based loader.