WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
66336
ResourceRequest::doUpdatePlatformRequest() should clear http method
https://bugs.webkit.org/show_bug.cgi?id=66336
Summary
ResourceRequest::doUpdatePlatformRequest() should clear http method
Pratik Solanki
Reported
2011-08-16 15:04:56 PDT
In ResourceRequestMac.mm, ResourceRequest::doUpdateResourceRequest() does if (NSString* method = [m_nsRequest.get() HTTPMethod]) m_httpMethod = method; This means that we don't clear out the m_httpMethod field if (e.g.) the NSURLRequest was nil. This can cause 2 ResourceRequests to be treated as different when they should be equal e.g. if the 2 ResourceRequests were created with different ctors. We have 2 different ResourceRequestBase actor - one sets the httpMethod to "GET" by default, the other doesn't do anything. By contrast on the CFNetwork side, we always clear out all the fields.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug