Bug 66308 - NRWT should honor --skipped=[default|ignore|only], like ORWT does
Summary: NRWT should honor --skipped=[default|ignore|only], like ORWT does
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 88680
  Show dependency tree / graph
 
Reported: 2011-08-16 08:59 PDT by Adam Roben (:aroben)
Modified: 2018-04-26 15:05 PDT (History)
10 users (show)

See Also:

Attachments
Patch (12.39 KB, patch)
2012-06-13 17:45 PDT, Dirk Pranke 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-08-16 08:59:11 PDT 
NRWT should honor this flag from ORWT:

  --skipped=[default|ignore|only] Specifies how to treat the Skipped file
                                     default: Tests/directories listed in the Skipped file are not tested
                                     ignore:  The Skipped file is ignored
                                     only:    Only those tests/directories listed in the Skipped file will be run
Comment 1 Dirk Pranke 2012-06-08 18:58:15 PDT 
Note that NRWT does have a -f/--force flag, which I think is roughly equivalent to --skipped=ignore . 

I would assume that this would treat tests marked as SKIP in the TestExpectations files the same way?

How should tests that are skipped either because of compile time flags or because they're in other platform directories be treated? The patch would be a lot easier if we ran those as well, but I could see how that might be undesirable.
Comment 2 Dirk Pranke 2012-06-13 17:45:11 PDT 
Created attachment 147450 [details]
Patch
Comment 3 Dirk Pranke 2012-06-14 12:40:18 PDT 
Committed r120348: <http://trac.webkit.org/changeset/120348>