Bug 66140 - Patch to fix GTK Windows build after r92308
Summary: Patch to fix GTK Windows build after r92308
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-12 09:20 PDT by Kalev Lember
Modified: 2011-08-14 05:22 PDT (History)
3 users (show)

See Also:


Attachments
Fix GTK Windows build after r92308. (1020 bytes, patch)
2011-08-12 09:23 PDT, Kalev Lember
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kalev Lember 2011-08-12 09:20:34 PDT
r92308 added #include <WebCore/WebCoreHeaderDetection.h> to config.h, but the file is not generated with the autotools build. To fix build breakage, disable the inclusion for GTK, similar to what's done for Qt and Chromium builds.
Comment 1 Kalev Lember 2011-08-12 09:23:31 PDT
Created attachment 103778 [details]
Fix GTK Windows build after r92308.
Comment 2 Jeff Miller 2011-08-12 10:50:06 PDT
Comment on attachment 103778 [details]
Fix GTK Windows build after r92308.

Thanks for fixing this. Looks fine to me, but I can't officially r+ the patch since I'm not a reviewer.
Comment 3 Kalev Lember 2011-08-13 01:53:29 PDT
Adam, this is a follow-up to the patch in bug #65634 you reviewed. Jeff said the patch is fine, but he is not a reviewer; could you please review this?

Thanks!
Comment 4 Xan Lopez 2011-08-14 03:22:14 PDT
Comment on attachment 103778 [details]
Fix GTK Windows build after r92308.

r=me
Comment 5 WebKit Review Bot 2011-08-14 05:22:11 PDT
Comment on attachment 103778 [details]
Fix GTK Windows build after r92308.

Clearing flags on attachment: 103778

Committed r93030: <http://trac.webkit.org/changeset/93030>
Comment 6 WebKit Review Bot 2011-08-14 05:22:15 PDT
All reviewed patches have been landed.  Closing bug.