RESOLVED FIXED Bug 65634
Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF 
https://bugs.webkit.org/show_bug.cgi?id=65634
Summary Generate WebCoreHeaderDetection.h on Windows to define HAVE_AVCF
Jeff Miller
Reported 2011-08-03 12:14:41 PDT
Generate WebCoreHeaderDetection.h on Windows to define WTF_USE_AVFOUNDATION
Attachments
Patch (3.13 KB, patch)
2011-08-03 12:26 PDT, Jeff Miller 		no flags
DetailsFormatted DiffDiff
Patch (2.95 KB, patch)
2011-08-03 12:48 PDT, Jeff Miller 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jeff Miller
Comment 1 2011-08-03 12:26:15 PDT
Created attachment 102810 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-08-03 12:29:53 PDT
Comment on attachment 102810 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102810&action=review > Source/WebCore/DerivedSources.make:984 > + if [ -f "$(WEBKITLIBRARIESDIR)/include/AVFoundationCF/AVCFBase.h" ]; then echo "#define WTF_USE_AVFOUNDATION 0" > $@; else echo > $@; fi I think we want to define a HAVE_* macro in WebCoreHeaderDetection.h, rather than a WTF_USE_* macro. WebCoreHeaderDetection.h should be all about what headers are available, not about policy decisions for which headers to use. config.h should have some logic like #if PLATFORM(WIN) && HAVE(AVCF) #define WTF_USE_AVFOUNDATION #endif
Jeff Miller
Comment 3 2011-08-03 12:48:31 PDT
Created attachment 102816 [details] Patch
Adam Roben (:aroben)
Comment 4 2011-08-03 12:51:05 PDT
Comment on attachment 102816 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102816&action=review > Source/WebCore/config.h:229 > +// FIXME(65400): Adopt AVCF media back end on Windows I think we normally include the WebKit bug URL rather than just the bug number. Something like: // FIXME: Adopt AVCF media back end on Windows http://webkit.org/b/65400
Jeff Miller
Comment 5 2011-08-03 13:16:17 PDT
Committed r92308: <http://trac.webkit.org/changeset/92308>
Jeff Miller
Comment 6 2011-08-03 13:16:57 PDT
<rdar://problem/9891394>
Note You need to log in before you can comment on or make changes to this bug.