Bug 66041 - nrwt's results.html should show crashed tests before flaky tests
Summary: nrwt's results.html should show crashed tests before flaky tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 64491
  Show dependency tree / graph
 
Reported: 2011-08-11 01:21 PDT by Ryosuke Niwa
Modified: 2011-10-14 15:39 PDT (History)
4 users (show)

See Also:

Attachments
fixes the bug (3.35 KB, patch)
2011-10-14 15:21 PDT, Ryosuke Niwa 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-08-11 01:21:28 PDT 
Since crashes are far more serious than flaky failures and turn the bots red unlike flaky tests, results.html should list them before flaky tests.
Comment 1 Ojan Vafai 2011-08-20 08:09:19 PDT 
I have no problem with this. I'm happy to review a patch with a test.
Comment 2 Eric Seidel (no email) 2011-10-12 14:41:29 PDT 
Easy to do.  Just needs a small change to results.html (which is just an html page):

http://trac.webkit.org/browser/trunk/LayoutTests/fast/harness/results.html
Comment 3 Ryosuke Niwa 2011-10-14 15:21:32 PDT 
Created attachment 111094 [details]
fixes the bug
Comment 4 Ojan Vafai 2011-10-14 15:34:12 PDT 
Comment on attachment 111094 [details]
fixes the bug

Yay. This has been driving me crazy. :) Thanks for writing tests!
Comment 5 Ryosuke Niwa 2011-10-14 15:39:19 PDT 
Committed r97522: <http://trac.webkit.org/changeset/97522>