Bug 65849 - [Meta] Spell-checking should share the unified text checker path.
Summary: [Meta] Spell-checking should share the unified text checker path.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Shinya Kawanaka
URL:
Keywords:
Depends on: 72929 45438 69128 70299
Blocks: 71991
  Show dependency treegraph
 
Reported: 2011-08-08 04:25 PDT by Hajime Morrita
Modified: 2012-08-29 23:33 PDT (History)
11 users (show)

See Also:


Attachments
WIP (34.39 KB, patch)
2011-08-08 04:33 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (37.07 KB, patch)
2011-08-22 21:13 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (43.01 KB, patch)
2011-08-22 22:37 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff
Patch (45.14 KB, patch)
2011-08-22 23:50 PDT, Hajime Morrita
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2011-08-08 04:25:46 PDT
Editor class has two different code paths for spell-checking:
One is for (A) using checkSpellingOfString() and checkGrammarOfString(), 
another is for (B) using  checkTextOfParagraph(), the unified text checker available for Mac OS SL or later.
Having this completely different code paths makes it hard to modify spellchecking code.

We could eliminate "A" by providing checkTextOfParagraph() equivalent
which only uses checkSpellingOfString() and checkGrammarOfString().
This emulation doesn't need to be perfect because current "A" behavior 
is subset of "B" anyway.

Such change would hugely simplify spellchecking code.
Comment 1 Hajime Morrita 2011-08-08 04:33:29 PDT
Created attachment 103228 [details]
WIP
Comment 2 Early Warning System Bot 2011-08-08 04:43:20 PDT
Comment on attachment 103228 [details]
WIP

Attachment 103228 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9329784
Comment 3 Gyuyoung Kim 2011-08-08 04:44:54 PDT
Comment on attachment 103228 [details]
WIP

Attachment 103228 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9323976
Comment 4 Gustavo Noronha (kov) 2011-08-08 04:56:37 PDT
Comment on attachment 103228 [details]
WIP

Attachment 103228 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/9325949
Comment 5 WebKit Review Bot 2011-08-08 05:03:45 PDT
Comment on attachment 103228 [details]
WIP

Attachment 103228 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9328806

New failing tests:
editing/pasteboard/merge-end-blockquote.html
editing/deleting/delete-block-contents-003.html
editing/pasteboard/merge-after-delete-2.html
editing/pasteboard/merge-after-delete.html
editing/pasteboard/merge-end-table.html
editing/spelling/spelling-backspace-between-lines.html
editing/selection/5234383-1.html
editing/deleting/delete-ws-fixup-002.html
editing/pasteboard/merge-end-list.html
editing/selection/5234383-2.html
editing/inserting/insert-div-016.html
editing/selection/move-backwords-by-word-001.html
editing/pasteboard/merge-after-delete-1.html
editing/spelling/spelling-attribute-change.html
editing/inserting/insert-div-018.html
editing/spelling/inline_spelling_markers.html
editing/selection/13804.html
editing/spelling/spelling-linebreak.html
editing/spelling/spelling.html
editing/deleting/delete-ws-fixup-001.html
Comment 6 WebKit Review Bot 2011-08-08 08:09:10 PDT
Comment on attachment 103228 [details]
WIP

Attachment 103228 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9331131
Comment 7 Hajime Morrita 2011-08-22 21:13:13 PDT
Created attachment 104787 [details]
Patch
Comment 8 Gyuyoung Kim 2011-08-22 21:22:53 PDT
Comment on attachment 104787 [details]
Patch

Attachment 104787 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9482033
Comment 9 Early Warning System Bot 2011-08-22 21:24:58 PDT
Comment on attachment 104787 [details]
Patch

Attachment 104787 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9481083
Comment 10 WebKit Review Bot 2011-08-22 21:51:38 PDT
Comment on attachment 104787 [details]
Patch

Attachment 104787 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/9482036
Comment 11 Hajime Morrita 2011-08-22 22:37:34 PDT
Created attachment 104789 [details]
Patch
Comment 12 Gyuyoung Kim 2011-08-22 22:47:42 PDT
Comment on attachment 104789 [details]
Patch

Attachment 104789 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/9475235
Comment 13 Early Warning System Bot 2011-08-22 22:50:03 PDT
Comment on attachment 104789 [details]
Patch

Attachment 104789 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/9477148
Comment 14 Hajime Morrita 2011-08-22 23:50:14 PDT
Created attachment 104793 [details]
Patch
Comment 15 Hajime Morrita 2011-08-23 02:24:48 PDT
It's almost green and ready to review!

This change looks large at a glance. But it's almost about removing the redundant code.
What essentially new is TextCheckingHelper::checkTextOfParagraph().