Bug 45438 - [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
Summary: [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Hajime Morrita
URL:
Keywords:
Depends on:
Blocks: 65849
  Show dependency tree / graph
 
Reported: 2010-09-08 21:28 PDT by Hajime Morrita
Modified: 2011-08-11 22:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.31 KB, patch)
2011-08-11 20:50 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Patch (6.75 KB, patch)
2011-08-11 21:38 PDT, Hajime Morrita 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Hajime Morrita 2010-09-08 21:28:35 PDT 
missing textInputController.hasSpellingMarker()
Comment 1 Hajime Morrita 2010-11-09 20:22:24 PST 
It doesn't look not related to hasSpellingmarker(). 
A string passed to EditorClient is not what expected.
Comment 2 Hajime Morrita 2011-08-11 20:50:32 PDT 
Created attachment 103729 [details]
Patch
Comment 3 Hajime Morrita 2011-08-11 20:53:01 PDT 
Kent-san, could you take a look?

This change also removes windows expectation, which was wrong, and was referred from
the chromium test runner unexpectedly, that made the failed test pass.
The change on MockSpellChecker fixes the problem so that chromium can match the correct expectation.
Comment 4 Kent Tamura 2011-08-11 21:02:41 PDT 
Comment on attachment 103729 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=103729&action=review

> LayoutTests/ChangeLog:11
> +        * platform/win/Skipped:
> +        * platform/win/editing/spelling/spelling-backspace-between-lines-expected.txt: Removed.

Apple Windows port has a policy that it contains failure expectations.
So, don't remove it.
Comment 5 Hajime Morrita 2011-08-11 21:38:31 PDT 
Created attachment 103731 [details]
Patch
Comment 6 Kent Tamura 2011-08-11 21:39:31 PDT 
Comment on attachment 103731 [details]
Patch

ok
Comment 7 Hajime Morrita 2011-08-11 21:40:01 PDT 
Comment on attachment 103731 [details]
Patch

Thanks!
Comment 8 WebKit Review Bot 2011-08-11 22:38:56 PDT 
Comment on attachment 103731 [details]
Patch

Clearing flags on attachment: 103731

Committed r92928: <http://trac.webkit.org/changeset/92928>
Comment 9 WebKit Review Bot 2011-08-11 22:39:00 PDT 
All reviewed patches have been landed.  Closing bug.