Bug 65740 – Remove LegacyDefaultOptionalArguments flag from XML/XSL IDL files

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Mark Pilgrim (Google)]

As discussed in IRC, we are migrating our IDL files away from the interface-level "LegacyDefaultOptionalArguments" flag and onto argument-level [Optional] or [Optional=CallWithDefaultValue] flags. This patch migrates XMLHttpRequest and XSL-related IDL files. It does not change any behavior, i.e. it does not make any arguments required that were previously optional, nor vice-versa.

All existing tests pass.

[Mark Pilgrim (Google)]

Created attachment 103028 [details]
Patch

[WebKit Review Bot]

Comment on attachment 103028 [details]
Patch

Clearing flags on attachment: 103028

Committed r92446: <http://trac.webkit.org/changeset/92446>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[noel gordon]

fyi, xsl test changed in this range http://trac.webkit.org/log/?verbose=on&rev=92450&stop_rev=92446

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=fast%2Fxsl%2Fimport-after-comment.xml%2Cfast%2Fxsl%2Fxslt-import-depth.xml%2Cfast%2Fxsl%2Fxslt-nested-stylesheets.xml%2Cfast%2Fxsl%2Fxslt-second-level-import.xml

[Adam Barth]

There was some discussion on IRC about http://trac.webkit.org/changeset/92448/ causing problems with XSLT.

[noel gordon]

Good to know.  Will add the same note to bug 65506.

[noel gordon]

Gardener wasn't sure about what changed either: bug 65757, bug 65758.

[Adam Barth]

We can try rolling out this patch, if we want to be sure.

[noel gordon]

Not needed -- bug 65757, bug 65758 state that some xsl tests started failing on chromium win/mac/linux.  But they pass on win locally for me at ToT.  The flakiness dashboard states that these tests need the expectations "MISSING CRASH", and the gardener dutifully added those :)  That dashboard can be misleading.  I see no regressions here.