Bug 65506 - Improve const-correctness in CSS code: type information methods
Summary: Improve const-correctness in CSS code: type information methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Minor
Assignee: Roland Steiner
URL:
Keywords:
Depends on: 65598
Blocks:
  Show dependency tree / graph
 
Reported: 2011-08-01 19:24 PDT by Roland Steiner
Modified: 2011-08-06 00:15 PDT (History)
9 users (show)

See Also:

Attachments
Patch (11.24 KB, patch)
2011-08-01 19:38 PDT, Roland Steiner 		simon.fraser: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2011-08-01 19:24:31 PDT 
Type information methods defined in StyleBase ("is...()" methods) and CSSRule ("type()" method) should be const, and - in the case of type() - return the enum type rather than a generic unsigned int.
Comment 1 Roland Steiner 2011-08-01 19:38:30 PDT 
Created attachment 102613 [details]
Patch
Comment 2 WebKit Review Bot 2011-08-01 19:59:40 PDT 
Comment on attachment 102613 [details]
Patch

Attachment 102613 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/9285611
Comment 3 WebKit Review Bot 2011-08-02 00:41:21 PDT 
Comment on attachment 102613 [details]
Patch

Attachment 102613 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/9289556
Comment 4 Roland Steiner 2011-08-03 00:47:40 PDT 
Build errors on Chromium bots should be fixed by patch to https://bugs.webkit.org/show_bug.cgi?id=65598.
Comment 5 Roland Steiner 2011-08-04 23:05:08 PDT 
Committed r92448: <http://trac.webkit.org/changeset/92448>
Comment 7 noel gordon 2011-08-06 00:15:06 PDT 
Tests went green eventually.