Bug 65529 - Make EventDispatchMediator refcounted.
Summary: Make EventDispatchMediator refcounted.
Alias: None
Product: WebKit
Classification: Unclassified
Component: UI Events (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hayato Ito
Depends on: 65593
Blocks: 64249
  Show dependency treegraph
Reported: 2011-08-02 05:17 PDT by Hayato Ito
Modified: 2011-08-03 03:17 PDT (History)
5 users (show)

See Also:

make EventDispatchMediator refcounted (10.77 KB, patch)
2011-08-02 05:22 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff
fix chromium win builds (10.79 KB, patch)
2011-08-02 23:27 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2011-08-02 05:17:25 PDT
This patch is one of the separated patches from bug 62429.

Make EventDispatchMediator refCounted so that it can be enqueued into a ScopedEventQueue and called later.
A necessary change for ScopedEventQueue should be addressed in another patch.
Comment 1 Hayato Ito 2011-08-02 05:19:22 PDT
s/ bug 62429 / bug 64249 /.
Comment 2 Hayato Ito 2011-08-02 05:22:32 PDT
Created attachment 102636 [details]
make EventDispatchMediator refcounted
Comment 3 Dimitri Glazkov (Google) 2011-08-02 09:21:40 PDT
Comment on attachment 102636 [details]
make EventDispatchMediator refcounted

ok. I initially imagined DispatchMediator to be a simple wrapper, but it does make sense that we should be able to stash it away for scoped events.
Comment 4 Hayato Ito 2011-08-02 20:26:39 PDT
Committed r92256: <http://trac.webkit.org/changeset/92256>
Comment 5 Hayato Ito 2011-08-02 23:27:39 PDT
Created attachment 102743 [details]
fix chromium win builds
Comment 6 Hayato Ito 2011-08-02 23:50:15 PDT
https://bugs.webkit.org/attachment.cgi?id=102636 caused tons of crashes on the chromium win bots.
See https://bugs.webkit.org/show_bug.cgi?id=65593.

Although I am not 100% sure why that failed only on chromium win bots, I guess the root cause is this terrible mistake:
  class EventDispatchMediator : public RefCounted<Event> 

I've fixed it.
Comment 7 Hayato Ito 2011-08-03 01:38:05 PDT
I've confirmed that chromium win bots didn't fail this time.
Comment 8 Hajime Morrita 2011-08-03 01:41:24 PDT
Comment on attachment 102743 [details]
fix chromium win builds

Let's see what happens
Comment 9 WebKit Review Bot 2011-08-03 03:17:46 PDT
Comment on attachment 102743 [details]
fix chromium win builds

Clearing flags on attachment: 102743

Committed r92266: <http://trac.webkit.org/changeset/92266>
Comment 10 WebKit Review Bot 2011-08-03 03:17:51 PDT
All reviewed patches have been landed.  Closing bug.