Bug 62429 – [EFL][WK2] Minor fix: fix coding style and remove unnecessary codes for WebKit2 efl port's PageClientImpl

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Eunmi Lee]

I fixed coding style and removed unnecessary codes in the WebPageProxyEfl and PageClientImpl.

[Eunmi Lee]

Created attachment 96696 [details]
Patch

[Eunmi Lee]

Created attachment 96698 [details]
Patch

[Eunmi Lee]

(In reply to comment #2)
> Created an attachment (id=96698) [details]
> Patch

I removed WTF::

[Gyuyoung Kim]

Comment on attachment 96698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=96698&action=review

> Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:57
> +        osVersion = String(name.sysname) + " " + String(name.machine);

I think makeString() is better than string operation. I also make a bug for similar implementation. (Bug 62434)

[Eunmi Lee]

Created attachment 96705 [details]
Patch

[Eunmi Lee]

(In reply to comment #4)
> (From update of attachment 96698 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=96698&action=review
> 
> > Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:57
> > +        osVersion = String(name.sysname) + " " + String(name.machine);
> 
> I think makeString() is better than string operation. I also make a bug for similar implementation. (Bug 62434)

Done.
Thanks for your comment :)
I fixed above codes to use makeString.

[Eunmi Lee]

(In reply to comment #5)
> Created an attachment (id=96705) [details]
> Patch

I fixed string operation to makeString,
and added enterAcceleratedCompositingMode and exitAcceleratedCompositingMode for ACCELERATED_COMPOSITING

[Leandro Pereira]

Comment on attachment 96705 [details]
Patch

There are some unrelated changes on this patch; please make these changes in different patches. This should help if a rollout is ever needed.

[Eunmi Lee]

Created attachment 96916 [details]
Patch

[Eunmi Lee]

(In reply to comment #8)
> (From update of attachment 96705 [details])
> There are some unrelated changes on this patch; please make these changes in different patches. This should help if a rollout is ever needed.

Thanks for your comments.
I've removed unrelated changes from this patch and I will make new patch for other changes.

[Leandro Pereira]

(In reply to comment #10)
> Thanks for your comments.
> I've removed unrelated changes from this patch and I will make new patch for 
> other changes.

Informal r+.

[Kenneth Rohde Christiansen]

Comment on attachment 96916 [details]
Patch

Making the informal r+, formal

[WebKit Review Bot]

Comment on attachment 96916 [details]
Patch

Clearing flags on attachment: 96916

Committed r88640: <http://trac.webkit.org/changeset/88640>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.