I fixed coding style and removed unnecessary codes in the WebPageProxyEfl and PageClientImpl.
Created attachment 96696 [details] Patch
Created attachment 96698 [details] Patch
(In reply to comment #2) > Created an attachment (id=96698) [details] > Patch I removed WTF::
Comment on attachment 96698 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=96698&action=review > Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:57 > + osVersion = String(name.sysname) + " " + String(name.machine); I think makeString() is better than string operation. I also make a bug for similar implementation. (Bug 62434)
Created attachment 96705 [details] Patch
(In reply to comment #4) > (From update of attachment 96698 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=96698&action=review > > > Source/WebKit2/UIProcess/efl/WebPageProxyEfl.cpp:57 > > + osVersion = String(name.sysname) + " " + String(name.machine); > > I think makeString() is better than string operation. I also make a bug for similar implementation. (Bug 62434) Done. Thanks for your comment :) I fixed above codes to use makeString.
(In reply to comment #5) > Created an attachment (id=96705) [details] > Patch I fixed string operation to makeString, and added enterAcceleratedCompositingMode and exitAcceleratedCompositingMode for ACCELERATED_COMPOSITING
Comment on attachment 96705 [details] Patch There are some unrelated changes on this patch; please make these changes in different patches. This should help if a rollout is ever needed.
Created attachment 96916 [details] Patch
(In reply to comment #8) > (From update of attachment 96705 [details]) > There are some unrelated changes on this patch; please make these changes in different patches. This should help if a rollout is ever needed. Thanks for your comments. I've removed unrelated changes from this patch and I will make new patch for other changes.
(In reply to comment #10) > Thanks for your comments. > I've removed unrelated changes from this patch and I will make new patch for > other changes. Informal r+.
Comment on attachment 96916 [details] Patch Making the informal r+, formal
Comment on attachment 96916 [details] Patch Clearing flags on attachment: 96916 Committed r88640: <http://trac.webkit.org/changeset/88640>
All reviewed patches have been landed. Closing bug.