Teach all ports about their test configurations.
Created attachment 102174 [details] Patch
This should make bug 65206 not break stuff.
Comment on attachment 102174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:753 > + @memoized I don't think that will work with Python 2.5
(In reply to comment #3) > (From update of attachment 102174 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:753 > > + @memoized > > I don't think that will work with Python 2.5 It seems to work fine. We baked our own, by the way: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py&exact_package=chromium
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 102174 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review > > > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:753 > > > + @memoized > > > > I don't think that will work with Python 2.5 > > It seems to work fine. We baked our own, by the way: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py&exact_package=chromium Oh, nice indeed!
Comment on attachment 102174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review Looks good, just a small nit. Thanks! > Tools/Scripts/webkitpy/layout_tests/port/base.py:756 > + test configurations for for this port.""" Double for
(In reply to comment #6) > (From update of attachment 102174 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review > > Looks good, just a small nit. Thanks! Thank you for review! > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:756 > > + test configurations for for this port.""" > > Double for It's double awesome! :P
Committed r91866: <http://trac.webkit.org/changeset/91866>