Bug 65278 - Teach all ports about their test configurations.
Summary: Teach all ports about their test configurations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 64385 65206
  Show dependency tree / graph
 
Reported: 2011-07-27 12:53 PDT by Dimitri Glazkov (Google)
Modified: 2011-07-27 14:07 PDT (History)
3 users (show)

See Also:

Attachments
Patch (23.77 KB, patch)
2011-07-27 13:06 PDT, Dimitri Glazkov (Google) 		pnormand: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-07-27 12:53:21 PDT 
Teach all ports about their test configurations.
Comment 1 Dimitri Glazkov (Google) 2011-07-27 13:06:47 PDT 
Created attachment 102174 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2011-07-27 13:10:45 PDT 
This should make bug 65206 not break stuff.
Comment 3 Philippe Normand 2011-07-27 13:23:23 PDT 
Comment on attachment 102174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:753
> +    @memoized

I don't think that will work with Python 2.5
Comment 4 Dimitri Glazkov (Google) 2011-07-27 13:29:01 PDT 
(In reply to comment #3)
> (From update of attachment 102174 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review
> 
> > Tools/Scripts/webkitpy/layout_tests/port/base.py:753
> > +    @memoized
> 
> I don't think that will work with Python 2.5

It seems to work fine. We baked our own, by the way: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py&exact_package=chromium
Comment 5 Philippe Normand 2011-07-27 13:48:54 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 102174 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review
> > 
> > > Tools/Scripts/webkitpy/layout_tests/port/base.py:753
> > > +    @memoized
> > 
> > I don't think that will work with Python 2.5
> 
> It seems to work fine. We baked our own, by the way: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py&exact_package=chromium

Oh, nice indeed!
Comment 6 Philippe Normand 2011-07-27 14:03:46 PDT 
Comment on attachment 102174 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review

Looks good, just a small nit. Thanks!

> Tools/Scripts/webkitpy/layout_tests/port/base.py:756
> +        test configurations for for this port."""

Double for
Comment 7 Dimitri Glazkov (Google) 2011-07-27 14:05:03 PDT 
(In reply to comment #6)
> (From update of attachment 102174 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review
> 
> Looks good, just a small nit. Thanks!

Thank you for review!

> 
> > Tools/Scripts/webkitpy/layout_tests/port/base.py:756
> > +        test configurations for for this port."""
> 
> Double for

It's double awesome! :P
Comment 8 Dimitri Glazkov (Google) 2011-07-27 14:07:05 PDT 
Committed r91866: <http://trac.webkit.org/changeset/91866>