RESOLVED FIXED65278
Teach all ports about their test configurations. 
https://bugs.webkit.org/show_bug.cgi?id=65278
Summary Teach all ports about their test configurations.
Dimitri Glazkov (Google)
Reported 2011-07-27 12:53:21 PDT
Teach all ports about their test configurations.
Attachments
Patch (23.77 KB, patch)
2011-07-27 13:06 PDT, Dimitri Glazkov (Google) 		pnormand: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-27 13:06:47 PDT
Created attachment 102174 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-07-27 13:10:45 PDT
This should make bug 65206 not break stuff.
Philippe Normand
Comment 3 2011-07-27 13:23:23 PDT
Comment on attachment 102174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review > Tools/Scripts/webkitpy/layout_tests/port/base.py:753 > + @memoized I don't think that will work with Python 2.5
Dimitri Glazkov (Google)
Comment 4 2011-07-27 13:29:01 PDT
(In reply to comment #3) > (From update of attachment 102174 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:753 > > + @memoized > > I don't think that will work with Python 2.5 It seems to work fine. We baked our own, by the way: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py&exact_package=chromium
Philippe Normand
Comment 5 2011-07-27 13:48:54 PDT
(In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 102174 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review > > > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:753 > > > + @memoized > > > > I don't think that will work with Python 2.5 > > It seems to work fine. We baked our own, by the way: http://codesearch.google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Tools/Scripts/webkitpy/common/memoized.py&exact_package=chromium Oh, nice indeed!
Philippe Normand
Comment 6 2011-07-27 14:03:46 PDT
Comment on attachment 102174 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review Looks good, just a small nit. Thanks! > Tools/Scripts/webkitpy/layout_tests/port/base.py:756 > + test configurations for for this port.""" Double for
Dimitri Glazkov (Google)
Comment 7 2011-07-27 14:05:03 PDT
(In reply to comment #6) > (From update of attachment 102174 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=102174&action=review > > Looks good, just a small nit. Thanks! Thank you for review! > > > Tools/Scripts/webkitpy/layout_tests/port/base.py:756 > > + test configurations for for this port.""" > > Double for It's double awesome! :P
Dimitri Glazkov (Google)
Comment 8 2011-07-27 14:07:05 PDT
Committed r91866: <http://trac.webkit.org/changeset/91866>
Note You need to log in before you can comment on or make changes to this bug.