RESOLVED FIXED 65206
Replace SpecificityCalculator with TestConfiguration-driven logic. 
https://bugs.webkit.org/show_bug.cgi?id=65206
Summary Replace SpecificityCalculator with TestConfiguration-driven logic.
Dimitri Glazkov (Google)
Reported 2011-07-26 13:54:41 PDT
Replace SpecificityCalculator with TestConfiguration-driven logic.
Attachments
Patch (25.05 KB, patch)
2011-07-26 14:03 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
proposed GTK follow-up patch (3.11 KB, patch)
2011-07-27 03:05 PDT, Philippe Normand 		dglazkov: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-07-26 14:03:43 PDT
Created attachment 102049 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-07-26 15:07:30 PDT
Comment on attachment 102049 [details] Patch Clearing flags on attachment: 102049 Committed r91792: <http://trac.webkit.org/changeset/91792>
Dimitri Glazkov (Google)
Comment 3 2011-07-26 15:07:33 PDT
All reviewed patches have been landed. Closing bug.
Philippe Normand
Comment 4 2011-07-27 02:05:24 PDT
This patch broke expectations parsing in GTK and Qt. Investigating the issue, any hint Dimitri?
Philippe Normand
Comment 5 2011-07-27 03:05:47 PDT
Created attachment 102116 [details] proposed GTK follow-up patch Something similar is needed for Qt.
Philippe Normand
Comment 6 2011-07-27 03:10:44 PDT
Reopening as the patch was rolled out. See Bug 65242.
Philippe Normand
Comment 7 2011-07-27 03:12:16 PDT
Comment on attachment 102049 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=102049&action=review > Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py:777 > + if self._test_config in expectation_line.matching_configurations: The root issue of GTK and Qt failure is here. Those ports originally don't have the version field of their test config set and this test fails for all expectations.
Dimitri Glazkov (Google)
Comment 8 2011-07-27 09:02:16 PDT
Comment on attachment 102116 [details] proposed GTK follow-up patch Your sense of smell is correct, the problem was that GTK actual bot configs aren't matching anything in the provided all_test_configurations(). The right fix is to teach all ports about all configs that are valid for them. I'll work on this today.
Dimitri Glazkov (Google)
Comment 9 2011-07-27 16:11:09 PDT
Committed r91878: <http://trac.webkit.org/changeset/91878>
Dimitri Glazkov (Google)
Comment 10 2011-07-27 16:50:43 PDT
(In reply to comment #9) > Committed r91878: <http://trac.webkit.org/changeset/91878> Looks like it worked this time! Phillippe, Ossy, please don't hesitate to roll out if you find troubles.
Note You need to log in before you can comment on or make changes to this bug.