Bug 65163 - [EFL] Fix pointer operator coding style in ewk_view
Summary: [EFL] Fix pointer operator coding style in ewk_view
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on: 65162
Blocks:
  Show dependency treegraph
 
Reported: 2011-07-25 21:26 PDT by Gyuyoung Kim
Modified: 2011-07-26 19:45 PDT (History)
6 users (show)

See Also:


Attachments
Proposed Patch (120.79 KB, patch)
2011-07-25 21:27 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff
Patch based on latest webkit (121.34 KB, patch)
2011-07-25 21:47 PDT, Gyuyoung Kim
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-07-25 21:26:23 PDT
Public APIs of port tends to be in the coding style of the embedding system. So, this patch moves '*' operator to variable according to efl coding style. In addition, add a space between '*' and variable in type casting. But, I wonder if implementation of public API also needs to follow coding style of embedding system. It looks GTK port only follows embedding coding style rule in .h file. In my patch, I modify both .h and .cpp for now.
Comment 1 Gyuyoung Kim 2011-07-25 21:27:57 PDT
Created attachment 101969 [details]
Proposed Patch
Comment 2 Gyuyoung Kim 2011-07-25 21:47:01 PDT
Created attachment 101970 [details]
Patch based on latest webkit
Comment 3 WebKit Review Bot 2011-07-25 21:48:23 PDT
Attachment 101970 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1

Last 3072 characters of output:
e between type name and * in Evas_Event_Mouse_Up *ev  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:488:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:496:  Declaration has space between type name and * in Evas_Event_Mouse_Move *ev  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:497:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:505:  Declaration has space between type name and * in Evas_Event_Key_Down *ev  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:506:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:514:  Declaration has space between type name and * in Evas_Event_Key_Up *ev  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:515:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:537:  Declaration has space between type name and * in Ewk_View_Private_Data *priv  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:782:  Declaration has space between type name and * in Ewk_View_Private_Data *priv  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:983:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:1541:  Declaration has space between type name and * in char *ewk_view_selection_get  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3018:  Declaration has space between type name and * in Ewk_View_Smart_Data *ewk_view_smart_data_get  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3132:  Declaration has space between type name and * in cairo_t *cr  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3148:  Declaration has space between type name and * in Ewk_View_Paint_Context *ewk_view_paint_context_new  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3155:  Declaration has space between type name and * in Ewk_View_Paint_Context *ctxt  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3536:  Declaration has space between type name and * in Evas_Object *frame  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3594:  Declaration has space between type name and * in Evas_Object *frame  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3680:  Declaration has space between type name and * in Evas_Object *ewk_view_window_create  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3687:  Declaration has space between type name and * in Ewk_Window_Features *window_features  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:4149:  Declaration has space between type name and * in Ewk_Menu_Item *item  [whitespace/declaration] [3]
Total errors found: 42 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-07-26 05:27:43 PDT
Personally I'm not very fond of EFL's style, but it would be good to have some consistency in the files, so r+ from my side.
Comment 5 Gyuyoung Kim 2011-07-26 18:11:18 PDT
CC'ing Eric, tkent, Could you please review this patch ?
Sorry for adding CC. But, it was difficult to find proper reviewers.
Comment 6 WebKit Review Bot 2011-07-26 19:45:47 PDT
Comment on attachment 101970 [details]
Patch based on latest webkit

Clearing flags on attachment: 101970

Committed r91815: <http://trac.webkit.org/changeset/91815>
Comment 7 WebKit Review Bot 2011-07-26 19:45:53 PDT
All reviewed patches have been landed.  Closing bug.