Bug 65163 – [EFL] Fix pointer operator coding style in ewk_view

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Gyuyoung Kim]

Public APIs of port tends to be in the coding style of the embedding system. So, this patch moves '*' operator to variable according to efl coding style. In addition, add a space between '*' and variable in type casting. But, I wonder if implementation of public API also needs to follow coding style of embedding system. It looks GTK port only follows embedding coding style rule in .h file. In my patch, I modify both .h and .cpp for now.

[Gyuyoung Kim]

Created attachment 101969 [details]
Proposed Patch

[Gyuyoung Kim]

Created attachment 101970 [details]
Patch based on latest webkit

[WebKit Review Bot]

Attachment 101970 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/efl/ChangeLog', u'Source/Web..." exit_code: 1

Last 3072 characters of output:
e between type name and * in Evas_Event_Mouse_Up *ev  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:488:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:496:  Declaration has space between type name and * in Evas_Event_Mouse_Move *ev  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:497:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:505:  Declaration has space between type name and * in Evas_Event_Key_Down *ev  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:506:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:514:  Declaration has space between type name and * in Evas_Event_Key_Up *ev  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:515:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:537:  Declaration has space between type name and * in Ewk_View_Private_Data *priv  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:782:  Declaration has space between type name and * in Ewk_View_Private_Data *priv  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:983:  Declaration has space between type name and * in Ewk_View_Smart_Data *sd  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:1541:  Declaration has space between type name and * in char *ewk_view_selection_get  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3018:  Declaration has space between type name and * in Ewk_View_Smart_Data *ewk_view_smart_data_get  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3132:  Declaration has space between type name and * in cairo_t *cr  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3148:  Declaration has space between type name and * in Ewk_View_Paint_Context *ewk_view_paint_context_new  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3155:  Declaration has space between type name and * in Ewk_View_Paint_Context *ctxt  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3536:  Declaration has space between type name and * in Evas_Object *frame  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3594:  Declaration has space between type name and * in Evas_Object *frame  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3680:  Declaration has space between type name and * in Evas_Object *ewk_view_window_create  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:3687:  Declaration has space between type name and * in Ewk_Window_Features *window_features  [whitespace/declaration] [3]
Source/WebKit/efl/ewk/ewk_view.cpp:4149:  Declaration has space between type name and * in Ewk_Menu_Item *item  [whitespace/declaration] [3]
Total errors found: 42 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Raphael Kubo da Costa (:rakuco)]

Personally I'm not very fond of EFL's style, but it would be good to have some consistency in the files, so r+ from my side.

[Gyuyoung Kim]

CC'ing Eric, tkent, Could you please review this patch ?
Sorry for adding CC. But, it was difficult to find proper reviewers.

[WebKit Review Bot]

Comment on attachment 101970 [details]
Patch based on latest webkit

Clearing flags on attachment: 101970

Committed r91815: <http://trac.webkit.org/changeset/91815>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.