Bug 65162 - Add an exception to coding style check for EFL port
Summary: Add an exception to coding style check for EFL port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 65163
  Show dependency tree / graph
 
Reported: 2011-07-25 21:13 PDT by Gyuyoung Kim
Modified: 2011-07-26 19:02 PDT (History)
4 users (show)

See Also:

Attachments
Proposed Patch (1.18 KB, patch)
2011-07-25 21:14 PDT, Gyuyoung Kim 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2011-07-25 21:13:04 PDT 
In EFL coding style, '*' operator is next to variable instead of data type. I think it is better to adhere the rule in efl port because port implementation tends to be in the style of the embedding system.
Comment 1 Gyuyoung Kim 2011-07-25 21:14:07 PDT 
Created attachment 101967 [details]
Proposed Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2011-07-26 05:13:47 PDT 
LGTM
Comment 3 Gyuyoung Kim 2011-07-26 18:10:48 PDT 
CC'ing Eric, tkent, Could you please review this patch ?
Sorry for adding CC. But, it was difficult to find proper reviewers.
Comment 4 Kent Tamura 2011-07-26 18:46:32 PDT 
Comment on attachment 101967 [details]
Proposed Patch

ok
Comment 5 WebKit Review Bot 2011-07-26 19:02:53 PDT 
Comment on attachment 101967 [details]
Proposed Patch

Clearing flags on attachment: 101967

Committed r91810: <http://trac.webkit.org/changeset/91810>
Comment 6 WebKit Review Bot 2011-07-26 19:02:58 PDT 
All reviewed patches have been landed.  Closing bug.