Bug 65074 - unicode-bidi:-webkit-plaintext does not work on <textarea>
Summary: unicode-bidi:-webkit-plaintext does not work on <textarea>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 50910
  Show dependency treegraph
 
Reported: 2011-07-24 05:59 PDT by Aharon (Vladimir) Lanin
Modified: 2011-07-27 16:18 PDT (History)
6 users (show)

See Also:


Attachments
test case (642 bytes, text/html)
2011-07-24 05:59 PDT, Aharon (Vladimir) Lanin
no flags Details
Patch (37.84 KB, patch)
2011-07-26 16:10 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch for landing (37.73 KB, patch)
2011-07-27 12:10 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff
Patch for landing (37.80 KB, patch)
2011-07-27 12:40 PDT, Levi Weintraub
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aharon (Vladimir) Lanin 2011-07-24 05:59:28 PDT
Created attachment 101827 [details]
test case

https://bugs.webkit.org/show_bug.cgi?id=50949 added support for unicode-bidi:-webkit-paintext, and made it the default for <pre dir=auto> and <textarea dir=auto>. However, although both dir=auto and unicode-bidi:-webkit-paintext work for <pre>, they do not work for <textarea>, where all paragraphs continue to have the same direction.
Comment 1 Levi Weintraub 2011-07-26 16:01:42 PDT
Thanks to Ryosuke for pointing me to the right spot for the fix. Uploading momentarily.
Comment 2 Levi Weintraub 2011-07-26 16:10:00 PDT
Created attachment 102069 [details]
Patch

Will re-upload with linux expectations once it fails on EWS. (Ugh :p)
Comment 3 Levi Weintraub 2011-07-27 11:10:57 PDT
Comment on attachment 102069 [details]
Patch

Looks like the Linux bot isn't being nice and uploading results anymore. Anyone care to review?
Comment 4 Ryosuke Niwa 2011-07-27 11:45:00 PDT
Comment on attachment 102069 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=102069&action=review

> LayoutTests/fast/text/international/unicode-bidi-plaintext-in-textarea.html:1
> +<!DOCTYPE html>

BOM?  Please remove it and add a meta tag for content-type instead.
Comment 5 Levi Weintraub 2011-07-27 12:10:11 PDT
Created attachment 102165 [details]
Patch for landing
Comment 6 Ryosuke Niwa 2011-07-27 12:36:49 PDT
Comment on attachment 102165 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=102165&action=review

> LayoutTests/fast/text/international/unicode-bidi-plaintext-in-textarea.html:1
> +<!DOCTYPE html>

You didn't remove DOM :(
Comment 7 Levi Weintraub 2011-07-27 12:40:46 PDT
Created attachment 102171 [details]
Patch for landing
Comment 8 Levi Weintraub 2011-07-27 16:16:29 PDT
Comment on attachment 102171 [details]
Patch for landing

Clearing flags on attachment: 102171

Committed r91879: <http://trac.webkit.org/changeset/91879>
Comment 9 Levi Weintraub 2011-07-27 16:18:07 PDT
Committed r91879: <http://trac.webkit.org/changeset/91879>