Bug 65072 - REGRESSION (Safari 5.0.5 - 5.1): No animation on svg-wow.org/text-effects/text-effects.xhtml
Summary: REGRESSION (Safari 5.0.5 - 5.1): No animation on svg-wow.org/text-effects/tex...
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nikolas Zimmermann
URL: http://svg-wow.org/text-effects/text-...
Depends on:
Blocks: 41761
  Show dependency treegraph
Reported: 2011-07-24 03:05 PDT by Dirk Schulze
Modified: 2012-04-03 08:55 PDT (History)
4 users (show)

See Also:

Patch (55.34 KB, patch)
2012-02-15 03:34 PST, Nikolas Zimmermann
zherczeg: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Schulze 2011-07-24 03:05:33 PDT
I couldn't check the problem on the test yet. I'll check it later. Just opening the bug so that I don't forget it. The test definitely works on Safari 5.0
Comment 1 Nikolas Zimmermann 2012-02-13 07:09:34 PST
An exception is thrown, NOT_SUPPORTED_ERR here "result = attrVal.baseVal.getItem(0).value;" in node-svg-debug.js, line 107. I debugged using inspector and found it that this example queries a SVGTextElement grabbings its y.baseVal, which is a SVGLengthList, and calls getItem(0) to get the SVGLength object, and then value() to get a float.

As it throws an exception on SVGLength.value, SVGLength couldn't resolve the unit. Quick debugging shows that: alert(this._node.getAttribute("y")); indeed returns "-0.5em".

this._node has no renderer, at the point where the script tries to query the SVG DOM, that's why it can't resolve ems/exs/percentage units. Maybe we shouldn't throw though, I'll investigate.
Comment 2 Nikolas Zimmermann 2012-02-13 08:13:10 PST
I have a fix for this, will tidy it up tomorrow.
Comment 3 Nikolas Zimmermann 2012-02-15 03:34:40 PST
Created attachment 127151 [details]
Comment 4 Zoltan Herczeg 2012-02-15 07:48:55 PST
Comment on attachment 127151 [details]

Comment 5 Nikolas Zimmermann 2012-02-16 04:59:08 PST
Committed r107923: <http://trac.webkit.org/changeset/107923>
Comment 6 Stephen Chenney 2012-04-03 08:55:25 PDT
Committed r113043: <http://trac.webkit.org/changeset/113043>