Bug 65059 – Add more testing to RenderLayer [ct'd]

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Julien Chaffraix]

Follow up of bug 64650, it adds more testing to the layering code to make sure everything is fine. This bug adds testing of <iframe> and more position: absolute when scrolling is involved.

[Julien Chaffraix]

Created attachment 101800 [details]
Proposed new test cases.

[Adrienne Walker]

If you don't mind me asking, why are there so many platform-specific differences here?

Also, yay tests!

[Julien Chaffraix]

(In reply to comment #2)
> If you don't mind me asking, why are there so many platform-specific differences here?

No worries, my guess is that Chromium unites the repaint rectangles instead of sending individual dirty rectangles which is what Mac is doing.

Then there is 2 tests where the invalidated rectangle looks wrong results on Mac, I have not investigated those 2 so I can't say why.

[James Robinson]

Comment on attachment 101800 [details]
Proposed new test cases.

According to the checksums the chromium and mac versions of absolute-position-change-containing-block-expected.png are identical, same for absolute-position-moved-expected.png and fixed-to-relative-position-with-absolute-child-expected.png.  would you mind de-duplicating these and putting the shared .pngs next to the test?  I didn't check all for dupes.

The comments in the tests seem a bit out of date - for example nested-iframe-scroll-outer.html talks about a red box, but there isn't any such box in the output (nor should there be red in the expectations for a pixel test).

[Julien Chaffraix]

Created attachment 102282 [details]
Updated test cases, shared images with the same checksum and updated the comments per James's request.

[James Robinson]

Comment on attachment 102282 [details]
Updated test cases, shared images with the same checksum and updated the comments per James's request.

R=me

[WebKit Review Bot]

Comment on attachment 102282 [details]
Updated test cases, shared images with the same checksum and updated the comments per James's request.

Clearing flags on attachment: 102282

Committed r92042: <http://trac.webkit.org/changeset/92042>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Adam Barth]

I fixed the baselines for this patch in http://trac.webkit.org/changeset/92066.

[Julien Chaffraix]

Filed bug 65580 for the 2 mac dumps being wrong.

[Julien Chaffraix]

(In reply to comment #9)
> I fixed the baselines for this patch in http://trac.webkit.org/changeset/92066.

Thanks Adam. I looked at the baseline and it looks like Chromium is repainting way too much in this one:

http://trac.webkit.org/browser/trunk/LayoutTests/platform/chromium-mac/fast/repaint/fixed-to-relative-position-with-absolute-child-expected.png

The rest is fine.