This is a prerequisite for bug 57571 as we lack coverage / validation of our current behavior.
Created attachment 101217 [details] Proposed test cases.
Created attachment 101415 [details] Fixed the tests to be repaint tests per Simon suggestion. This should cover correctness too anyway.
Comment on attachment 101415 [details] Fixed the tests to be repaint tests per Simon suggestion. This should cover correctness too anyway. The render tree dump itself is unfortunately nearly always platform-specific. If the pixel output is the important thing to test (as I think is the case for these tests), you can do layoutTestController.dumpAsText(true); to cause the output to be pixel results + dumpAsText() results, without any render tree. That should be a bit stabler. I'm kind of surprised that we repaint the entire viewport in fixed-scroll-simple.html. What platform were these results generated on?
> The render tree dump itself is unfortunately nearly always platform-specific. > If the pixel output is the important thing to test (as I think is the case for > these tests), you can do layoutTestController.dumpAsText(true); to cause the > output to be pixel results + dumpAsText() results, without any render tree. > That should be a bit stabler. It would make sense. I retried and it looks like the render tree dump is OK here. The images are different though. I will see what I can do to get something stable enough. > I'm kind of surprised that we repaint the entire viewport in fixed-scroll-simple.html. What platform were these results generated on? As discussed briefly, those results were generated on chromium-linux but I have checked that mac and qt have similar results though.
Created attachment 101676 [details] Added the platform images that differed but shared the RenderTree dump.
Created attachment 101758 [details] Made dumpAsText(true) per James's request.
Comment on attachment 101758 [details] Made dumpAsText(true) per James's request. Great, these look good.
Comment on attachment 101758 [details] Made dumpAsText(true) per James's request. Clearing flags on attachment: 101758 Committed r91605: <http://trac.webkit.org/changeset/91605>
All reviewed patches have been landed. Closing bug.