RESOLVED FIXED 64650
RenderLayer fixed position logic needs more basic testing 
https://bugs.webkit.org/show_bug.cgi?id=64650
Summary RenderLayer fixed position logic needs more basic testing
Julien Chaffraix
Reported 2011-07-16 07:48:34 PDT
This is a prerequisite for bug 57571 as we lack coverage / validation of our current behavior.
Attachments
Proposed test cases. (19.83 KB, patch)
2011-07-18 15:18 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Fixed the tests to be repaint tests per Simon suggestion. This should cover correctness too anyway. (19.65 KB, patch)
2011-07-19 18:14 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Added the platform images that differed but shared the RenderTree dump. (38.34 KB, patch)
2011-07-21 17:37 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Made dumpAsText(true) per James's request. (34.72 KB, patch)
2011-07-22 13:20 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-07-18 15:18:18 PDT
Created attachment 101217 [details] Proposed test cases.
Julien Chaffraix
Comment 2 2011-07-19 18:14:20 PDT
Created attachment 101415 [details] Fixed the tests to be repaint tests per Simon suggestion. This should cover correctness too anyway.
James Robinson
Comment 3 2011-07-21 15:15:45 PDT
Comment on attachment 101415 [details] Fixed the tests to be repaint tests per Simon suggestion. This should cover correctness too anyway. The render tree dump itself is unfortunately nearly always platform-specific. If the pixel output is the important thing to test (as I think is the case for these tests), you can do layoutTestController.dumpAsText(true); to cause the output to be pixel results + dumpAsText() results, without any render tree. That should be a bit stabler. I'm kind of surprised that we repaint the entire viewport in fixed-scroll-simple.html. What platform were these results generated on?
Julien Chaffraix
Comment 4 2011-07-21 17:19:41 PDT
> The render tree dump itself is unfortunately nearly always platform-specific. > If the pixel output is the important thing to test (as I think is the case for > these tests), you can do layoutTestController.dumpAsText(true); to cause the > output to be pixel results + dumpAsText() results, without any render tree. > That should be a bit stabler. It would make sense. I retried and it looks like the render tree dump is OK here. The images are different though. I will see what I can do to get something stable enough. > I'm kind of surprised that we repaint the entire viewport in fixed-scroll-simple.html. What platform were these results generated on? As discussed briefly, those results were generated on chromium-linux but I have checked that mac and qt have similar results though.
Julien Chaffraix
Comment 5 2011-07-21 17:37:15 PDT
Created attachment 101676 [details] Added the platform images that differed but shared the RenderTree dump.
Julien Chaffraix
Comment 6 2011-07-22 13:20:45 PDT
Created attachment 101758 [details] Made dumpAsText(true) per James's request.
James Robinson
Comment 7 2011-07-22 13:30:15 PDT
Comment on attachment 101758 [details] Made dumpAsText(true) per James's request. Great, these look good.
WebKit Review Bot
Comment 8 2011-07-22 14:28:25 PDT
Comment on attachment 101758 [details] Made dumpAsText(true) per James's request. Clearing flags on attachment: 101758 Committed r91605: <http://trac.webkit.org/changeset/91605>
WebKit Review Bot
Comment 9 2011-07-22 14:28:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.