RESOLVED FIXED 64961
Replace preprocessor statements in IDL files with Conditional attribute 
https://bugs.webkit.org/show_bug.cgi?id=64961
Summary Replace preprocessor statements in IDL files with Conditional attribute
Patrick R. Gansterer
Reported 2011-07-21 10:26:19 PDT
Replace preprocessor statements in IDL files with Conditional attribute
Attachments
Patch (6.62 KB, patch)
2011-07-21 10:55 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-07-21 10:55:37 PDT
Created attachment 101605 [details] Patch
Darin Adler
Comment 2 2011-07-21 12:50:40 PDT
Comment on attachment 101605 [details] Patch What’s the rationale? Why is this better?
Patrick R. Gansterer
Comment 3 2011-07-21 13:03:47 PDT
(In reply to comment #2) > (From update of attachment 101605 [details]) > What’s the rationale? Why is this better? The preprocessor causes many problems on native windows (e.g. no support for spaces in path) for me. See also <http://trac.webkit.org/changeset/90717>
Darin Adler
Comment 4 2011-07-22 07:51:55 PDT
(In reply to comment #3) > The preprocessor causes many problems on native windows (e.g. no support for spaces in path) for me. > See also <http://trac.webkit.org/changeset/90717> In the future please make a brief mention of motivation like this in the change log entry.
WebKit Review Bot
Comment 5 2011-07-22 08:50:50 PDT
Comment on attachment 101605 [details] Patch Clearing flags on attachment: 101605 Committed r91570: <http://trac.webkit.org/changeset/91570>
WebKit Review Bot
Comment 6 2011-07-22 08:50:55 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.