Bug 64961 - Replace preprocessor statements in IDL files with Conditional attribute
Summary: Replace preprocessor statements in IDL files with Conditional attribute
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on: 64231
Blocks: 67400
  Show dependency treegraph
 
Reported: 2011-07-21 10:26 PDT by Patrick R. Gansterer
Modified: 2011-09-01 07:29 PDT (History)
2 users (show)

See Also:


Attachments
Patch (6.62 KB, patch)
2011-07-21 10:55 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2011-07-21 10:26:19 PDT
Replace preprocessor statements in IDL files with Conditional attribute
Comment 1 Patrick R. Gansterer 2011-07-21 10:55:37 PDT
Created attachment 101605 [details]
Patch
Comment 2 Darin Adler 2011-07-21 12:50:40 PDT
Comment on attachment 101605 [details]
Patch

What’s the rationale? Why is this better?
Comment 3 Patrick R. Gansterer 2011-07-21 13:03:47 PDT
(In reply to comment #2)
> (From update of attachment 101605 [details])
> What’s the rationale? Why is this better?

The preprocessor causes many problems on native windows (e.g. no support for spaces in path) for me.
See also <http://trac.webkit.org/changeset/90717>
Comment 4 Darin Adler 2011-07-22 07:51:55 PDT
(In reply to comment #3)
> The preprocessor causes many problems on native windows (e.g. no support for spaces in path) for me.
> See also <http://trac.webkit.org/changeset/90717>

In the future please make a brief mention of motivation like this in the change log entry.
Comment 5 WebKit Review Bot 2011-07-22 08:50:50 PDT
Comment on attachment 101605 [details]
Patch

Clearing flags on attachment: 101605

Committed r91570: <http://trac.webkit.org/changeset/91570>
Comment 6 WebKit Review Bot 2011-07-22 08:50:55 PDT
All reviewed patches have been landed.  Closing bug.